Re: [PATCHv3 4/4] arm64: Enable perf events based hard lockup detector

From: kernel test robot <lkp@intel.com>
To: Pingfan Liu <kernelfans@gmail.com>, linux-arm-kernel@lists.infradead.org
Cc: kbuild-all@lists.01.org, Sumit Garg <sumit.garg@linaro.org>,
	Pingfan Liu <kernelfans@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCHv3 4/4] arm64: Enable perf events based hard lockup detector
Date: Tue, 26 Oct 2021 18:20:04 +0800	[thread overview]
Message-ID: <202110261848.mBeeevhv-lkp@intel.com> (raw)
In-Reply-To: <20211014024155.15253-5-kernelfans@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2258 bytes --]

Hi Pingfan,

I love your patch! Yet something to improve:

[auto build test ERROR on soc/for-next]
[also build test ERROR on kvmarm/next linus/master v5.15-rc7 next-20211025]
[cannot apply to arm64/for-next/core arm/for-next xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pingfan-Liu/watchdog_hld-cleanup-and-async-model-for-arm64/20211014-104443
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: arm64-randconfig-r012-20211025 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4c319c41e49036be58068395965bd33a5de02396
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pingfan-Liu/watchdog_hld-cleanup-and-async-model-for-arm64/20211014-104443
        git checkout 4c319c41e49036be58068395965bd33a5de02396
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/arm64/kernel/watchdog_hld.c: In function 'watchdog_nmi_probe':
>> arch/arm64/kernel/watchdog_hld.c:32:19: error: implicit declaration of function 'arm_pmu_irq_is_nmi' [-Werror=implicit-function-declaration]
      32 |         else if (!arm_pmu_irq_is_nmi())
         |                   ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/arm_pmu_irq_is_nmi +32 arch/arm64/kernel/watchdog_hld.c

    27	
    28	int __init watchdog_nmi_probe(void)
    29	{
    30		if (detector_delay_init_state != DELAY_INIT_READY)
    31			return -EBUSY;
  > 32		else if (!arm_pmu_irq_is_nmi())

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50024 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel