All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	linux-acpi@vger.kernel.org
Cc: kbuild-all@lists.01.org, markpearson@lenovo.com,
	pobrn@protonmail.com,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v2] ACPI: platform_profile: Add support for notification chains
Date: Tue, 26 Oct 2021 19:31:38 +0800	[thread overview]
Message-ID: <202110261903.63mZF71S-lkp@intel.com> (raw)
In-Reply-To: <20211025210303.29083-1-mario.limonciello@amd.com>

[-- Attachment #1: Type: text/plain, Size: 4719 bytes --]

Hi Mario,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mario-Limonciello/ACPI-platform_profile-Add-support-for-notification-chains/20211026-050443
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/753ef2d5047b65eb707df546173703ca66305f95
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mario-Limonciello/ACPI-platform_profile-Add-support-for-notification-chains/20211026-050443
        git checkout 753ef2d5047b65eb707df546173703ca66305f95
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/ fs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/platform/x86/asus-wmi.c:2172:12: error: conflicting types for 'platform_profile_get'
    2172 | static int platform_profile_get(struct platform_profile_handler *pprof,
         |            ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/platform/x86/asus-wmi.c:29:
   include/linux/platform_profile.h:42:5: note: previous declaration of 'platform_profile_get' was here
      42 | int platform_profile_get(enum platform_profile_option *profile);
         |     ^~~~~~~~~~~~~~~~~~~~
--
>> drivers/platform/x86/hp-wmi.c:892:12: error: conflicting types for 'platform_profile_get'
     892 | static int platform_profile_get(struct platform_profile_handler *pprof,
         |            ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/platform/x86/hp-wmi.c:24:
   include/linux/platform_profile.h:42:5: note: previous declaration of 'platform_profile_get' was here
      42 | int platform_profile_get(enum platform_profile_option *profile);
         |     ^~~~~~~~~~~~~~~~~~~~


vim +/platform_profile_get +2172 drivers/platform/x86/asus-wmi.c

2daa86e78c494d Leonid Maksymchuk 2019-12-15  2170  
c63d44ae602419 Luke D. Jones     2021-08-19  2171  /* Platform profile ***********************************************************/
c63d44ae602419 Luke D. Jones     2021-08-19 @2172  static int platform_profile_get(struct platform_profile_handler *pprof,
c63d44ae602419 Luke D. Jones     2021-08-19  2173  				enum platform_profile_option *profile)
c63d44ae602419 Luke D. Jones     2021-08-19  2174  {
c63d44ae602419 Luke D. Jones     2021-08-19  2175  	struct asus_wmi *asus;
c63d44ae602419 Luke D. Jones     2021-08-19  2176  	int tp;
c63d44ae602419 Luke D. Jones     2021-08-19  2177  
c63d44ae602419 Luke D. Jones     2021-08-19  2178  	asus = container_of(pprof, struct asus_wmi, platform_profile_handler);
c63d44ae602419 Luke D. Jones     2021-08-19  2179  
c63d44ae602419 Luke D. Jones     2021-08-19  2180  	tp = asus->throttle_thermal_policy_mode;
c63d44ae602419 Luke D. Jones     2021-08-19  2181  
c63d44ae602419 Luke D. Jones     2021-08-19  2182  	switch (tp) {
c63d44ae602419 Luke D. Jones     2021-08-19  2183  	case ASUS_THROTTLE_THERMAL_POLICY_DEFAULT:
c63d44ae602419 Luke D. Jones     2021-08-19  2184  		*profile = PLATFORM_PROFILE_BALANCED;
c63d44ae602419 Luke D. Jones     2021-08-19  2185  		break;
c63d44ae602419 Luke D. Jones     2021-08-19  2186  	case ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST:
c63d44ae602419 Luke D. Jones     2021-08-19  2187  		*profile = PLATFORM_PROFILE_PERFORMANCE;
c63d44ae602419 Luke D. Jones     2021-08-19  2188  		break;
c63d44ae602419 Luke D. Jones     2021-08-19  2189  	case ASUS_THROTTLE_THERMAL_POLICY_SILENT:
c63d44ae602419 Luke D. Jones     2021-08-19  2190  		*profile = PLATFORM_PROFILE_QUIET;
c63d44ae602419 Luke D. Jones     2021-08-19  2191  		break;
c63d44ae602419 Luke D. Jones     2021-08-19  2192  	default:
c63d44ae602419 Luke D. Jones     2021-08-19  2193  		return -EINVAL;
c63d44ae602419 Luke D. Jones     2021-08-19  2194  	}
c63d44ae602419 Luke D. Jones     2021-08-19  2195  
c63d44ae602419 Luke D. Jones     2021-08-19  2196  	return 0;
c63d44ae602419 Luke D. Jones     2021-08-19  2197  }
c63d44ae602419 Luke D. Jones     2021-08-19  2198  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38478 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] ACPI: platform_profile: Add support for notification chains
Date: Tue, 26 Oct 2021 19:31:38 +0800	[thread overview]
Message-ID: <202110261903.63mZF71S-lkp@intel.com> (raw)
In-Reply-To: <20211025210303.29083-1-mario.limonciello@amd.com>

[-- Attachment #1: Type: text/plain, Size: 4801 bytes --]

Hi Mario,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mario-Limonciello/ACPI-platform_profile-Add-support-for-notification-chains/20211026-050443
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/753ef2d5047b65eb707df546173703ca66305f95
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mario-Limonciello/ACPI-platform_profile-Add-support-for-notification-chains/20211026-050443
        git checkout 753ef2d5047b65eb707df546173703ca66305f95
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/ fs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/platform/x86/asus-wmi.c:2172:12: error: conflicting types for 'platform_profile_get'
    2172 | static int platform_profile_get(struct platform_profile_handler *pprof,
         |            ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/platform/x86/asus-wmi.c:29:
   include/linux/platform_profile.h:42:5: note: previous declaration of 'platform_profile_get' was here
      42 | int platform_profile_get(enum platform_profile_option *profile);
         |     ^~~~~~~~~~~~~~~~~~~~
--
>> drivers/platform/x86/hp-wmi.c:892:12: error: conflicting types for 'platform_profile_get'
     892 | static int platform_profile_get(struct platform_profile_handler *pprof,
         |            ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/platform/x86/hp-wmi.c:24:
   include/linux/platform_profile.h:42:5: note: previous declaration of 'platform_profile_get' was here
      42 | int platform_profile_get(enum platform_profile_option *profile);
         |     ^~~~~~~~~~~~~~~~~~~~


vim +/platform_profile_get +2172 drivers/platform/x86/asus-wmi.c

2daa86e78c494d Leonid Maksymchuk 2019-12-15  2170  
c63d44ae602419 Luke D. Jones     2021-08-19  2171  /* Platform profile ***********************************************************/
c63d44ae602419 Luke D. Jones     2021-08-19 @2172  static int platform_profile_get(struct platform_profile_handler *pprof,
c63d44ae602419 Luke D. Jones     2021-08-19  2173  				enum platform_profile_option *profile)
c63d44ae602419 Luke D. Jones     2021-08-19  2174  {
c63d44ae602419 Luke D. Jones     2021-08-19  2175  	struct asus_wmi *asus;
c63d44ae602419 Luke D. Jones     2021-08-19  2176  	int tp;
c63d44ae602419 Luke D. Jones     2021-08-19  2177  
c63d44ae602419 Luke D. Jones     2021-08-19  2178  	asus = container_of(pprof, struct asus_wmi, platform_profile_handler);
c63d44ae602419 Luke D. Jones     2021-08-19  2179  
c63d44ae602419 Luke D. Jones     2021-08-19  2180  	tp = asus->throttle_thermal_policy_mode;
c63d44ae602419 Luke D. Jones     2021-08-19  2181  
c63d44ae602419 Luke D. Jones     2021-08-19  2182  	switch (tp) {
c63d44ae602419 Luke D. Jones     2021-08-19  2183  	case ASUS_THROTTLE_THERMAL_POLICY_DEFAULT:
c63d44ae602419 Luke D. Jones     2021-08-19  2184  		*profile = PLATFORM_PROFILE_BALANCED;
c63d44ae602419 Luke D. Jones     2021-08-19  2185  		break;
c63d44ae602419 Luke D. Jones     2021-08-19  2186  	case ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST:
c63d44ae602419 Luke D. Jones     2021-08-19  2187  		*profile = PLATFORM_PROFILE_PERFORMANCE;
c63d44ae602419 Luke D. Jones     2021-08-19  2188  		break;
c63d44ae602419 Luke D. Jones     2021-08-19  2189  	case ASUS_THROTTLE_THERMAL_POLICY_SILENT:
c63d44ae602419 Luke D. Jones     2021-08-19  2190  		*profile = PLATFORM_PROFILE_QUIET;
c63d44ae602419 Luke D. Jones     2021-08-19  2191  		break;
c63d44ae602419 Luke D. Jones     2021-08-19  2192  	default:
c63d44ae602419 Luke D. Jones     2021-08-19  2193  		return -EINVAL;
c63d44ae602419 Luke D. Jones     2021-08-19  2194  	}
c63d44ae602419 Luke D. Jones     2021-08-19  2195  
c63d44ae602419 Luke D. Jones     2021-08-19  2196  	return 0;
c63d44ae602419 Luke D. Jones     2021-08-19  2197  }
c63d44ae602419 Luke D. Jones     2021-08-19  2198  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38478 bytes --]

  reply	other threads:[~2021-10-26 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 21:03 [PATCH v2] ACPI: platform_profile: Add support for notification chains Mario Limonciello
2021-10-26 11:31 ` kernel test robot [this message]
2021-10-26 11:31   ` kernel test robot
2021-10-29  0:58 ` kernel test robot
2021-10-29  0:58   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110261903.63mZF71S-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=markpearson@lenovo.com \
    --cc=pobrn@protonmail.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.