Re: [PATCH v4 04/11] regulator: Introduce tps68470-regulator driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3220 bytes --]

Hi Hans,

I love your patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on rafael-pm/linux-next linus/master v5.15-rc7]
[cannot apply to broonie-regulator/for-next next-20211026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/Add-support-for-X86-ACPI-camera-sensor-PMIC-setup-with-clk-and-regulator-platform-data/20211025-174519
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: h8300-buildonly-randconfig-r002-20211026 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9e391d80739a2e630f2a50be79bf4d09b3c9f1bb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hans-de-Goede/Add-support-for-X86-ACPI-camera-sensor-PMIC-setup-with-clk-and-regulator-platform-data/20211025-174519
        git checkout 9e391d80739a2e630f2a50be79bf4d09b3c9f1bb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/regulator/tps68470-regulator.c:58:5: warning: no previous prototype for 'tps68470_regulator_enable' [-Wmissing-prototypes]
      58 | int tps68470_regulator_enable(struct regulator_dev *rdev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/regulator/tps68470-regulator.c:75:5: warning: no previous prototype for 'tps68470_regulator_disable' [-Wmissing-prototypes]
      75 | int tps68470_regulator_disable(struct regulator_dev *rdev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/tps68470_regulator_enable +58 drivers/regulator/tps68470-regulator.c

    57	
  > 58	int tps68470_regulator_enable(struct regulator_dev *rdev)
    59	{
    60		struct tps68470_regulator_data *data = rdev->reg_data;
    61		int ret;
    62	
    63		/* The Core buck regulator needs the PMIC's PLL to be enabled */
    64		if (rdev->desc->id == TPS68470_CORE) {
    65			ret = clk_prepare_enable(data->clk);
    66			if (ret) {
    67				dev_err(&rdev->dev, "Error enabling TPS68470 clock\n");
    68				return ret;
    69			}
    70		}
    71	
    72		return regulator_enable_regmap(rdev);
    73	}
    74	
  > 75	int tps68470_regulator_disable(struct regulator_dev *rdev)
    76	{
    77		struct tps68470_regulator_data *data = rdev->reg_data;
    78	
    79		if (rdev->desc->id == TPS68470_CORE)
    80			clk_disable_unprepare(data->clk);
    81	
    82		return regulator_disable_regmap(rdev);
    83	}
    84	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36320 bytes --]