From: kernel test robot <lkp@intel.com>
To: Lukas Czerner <lczerner@redhat.com>,
linux-ext4@vger.kernel.org, tytso@mit.edu
Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 08/13] ext4: get rid of super block and sbi from handle_mount_ops()
Date: Wed, 27 Oct 2021 09:32:51 +0800 [thread overview]
Message-ID: <202110270919.5evQEaqz-lkp@intel.com> (raw)
In-Reply-To: <20211021114508.21407-9-lczerner@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2807 bytes --]
Hi Lukas,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on d9abdee5fd5abffd0e763e52fbfa3116de167822]
url: https://github.com/0day-ci/linux/commits/Lukas-Czerner/ext4-new-mount-API-conversion/20211021-194735
base: d9abdee5fd5abffd0e763e52fbfa3116de167822
config: arc-buildonly-randconfig-r003-20211026 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7a72c1e0e5cd5dfab89d8122ebfb47a73e2efc27
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lukas-Czerner/ext4-new-mount-API-conversion/20211021-194735
git checkout 7a72c1e0e5cd5dfab89d8122ebfb47a73e2efc27
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ext4/super.c: In function 'ext4_validate_options':
>> fs/ext4/super.c:2947:33: error: unused variable 'ctx' [-Werror=unused-variable]
2947 | struct ext4_fs_context *ctx = fc->fs_private;
| ^~~
fs/ext4/super.c: In function 'ext4_remount':
fs/ext4/super.c:6210:13: error: variable 'enable_quota' set but not used [-Werror=unused-but-set-variable]
6210 | int enable_quota = 0;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/ctx +2947 fs/ext4/super.c
2943
2944
2945 static int ext4_validate_options(struct fs_context *fc)
2946 {
> 2947 struct ext4_fs_context *ctx = fc->fs_private;
2948 #ifdef CONFIG_QUOTA
2949 char *usr_qf_name, *grp_qf_name;
2950
2951 usr_qf_name = ctx->s_qf_names[USRQUOTA];
2952 grp_qf_name = ctx->s_qf_names[GRPQUOTA];
2953
2954 if (usr_qf_name || grp_qf_name) {
2955 if (ctx_test_mount_opt(ctx, EXT4_MOUNT_USRQUOTA) && usr_qf_name)
2956 ctx_clear_mount_opt(ctx, EXT4_MOUNT_USRQUOTA);
2957
2958 if (ctx_test_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA) && grp_qf_name)
2959 ctx_clear_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA);
2960
2961 if (ctx_test_mount_opt(ctx, EXT4_MOUNT_USRQUOTA) ||
2962 ctx_test_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA)) {
2963 ext4_msg(NULL, KERN_ERR, "old and new quota "
2964 "format mixing");
2965 return -EINVAL;
2966 }
2967 }
2968 #endif
2969 return 1;
2970 }
2971
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27925 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 08/13] ext4: get rid of super block and sbi from handle_mount_ops()
Date: Wed, 27 Oct 2021 09:32:51 +0800 [thread overview]
Message-ID: <202110270919.5evQEaqz-lkp@intel.com> (raw)
In-Reply-To: <20211021114508.21407-9-lczerner@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2880 bytes --]
Hi Lukas,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on d9abdee5fd5abffd0e763e52fbfa3116de167822]
url: https://github.com/0day-ci/linux/commits/Lukas-Czerner/ext4-new-mount-API-conversion/20211021-194735
base: d9abdee5fd5abffd0e763e52fbfa3116de167822
config: arc-buildonly-randconfig-r003-20211026 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7a72c1e0e5cd5dfab89d8122ebfb47a73e2efc27
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lukas-Czerner/ext4-new-mount-API-conversion/20211021-194735
git checkout 7a72c1e0e5cd5dfab89d8122ebfb47a73e2efc27
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ext4/super.c: In function 'ext4_validate_options':
>> fs/ext4/super.c:2947:33: error: unused variable 'ctx' [-Werror=unused-variable]
2947 | struct ext4_fs_context *ctx = fc->fs_private;
| ^~~
fs/ext4/super.c: In function 'ext4_remount':
fs/ext4/super.c:6210:13: error: variable 'enable_quota' set but not used [-Werror=unused-but-set-variable]
6210 | int enable_quota = 0;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/ctx +2947 fs/ext4/super.c
2943
2944
2945 static int ext4_validate_options(struct fs_context *fc)
2946 {
> 2947 struct ext4_fs_context *ctx = fc->fs_private;
2948 #ifdef CONFIG_QUOTA
2949 char *usr_qf_name, *grp_qf_name;
2950
2951 usr_qf_name = ctx->s_qf_names[USRQUOTA];
2952 grp_qf_name = ctx->s_qf_names[GRPQUOTA];
2953
2954 if (usr_qf_name || grp_qf_name) {
2955 if (ctx_test_mount_opt(ctx, EXT4_MOUNT_USRQUOTA) && usr_qf_name)
2956 ctx_clear_mount_opt(ctx, EXT4_MOUNT_USRQUOTA);
2957
2958 if (ctx_test_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA) && grp_qf_name)
2959 ctx_clear_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA);
2960
2961 if (ctx_test_mount_opt(ctx, EXT4_MOUNT_USRQUOTA) ||
2962 ctx_test_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA)) {
2963 ext4_msg(NULL, KERN_ERR, "old and new quota "
2964 "format mixing");
2965 return -EINVAL;
2966 }
2967 }
2968 #endif
2969 return 1;
2970 }
2971
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27925 bytes --]
next prev parent reply other threads:[~2021-10-27 1:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 11:44 [PATCH v3 00/13] ext4: new mount API conversion Lukas Czerner
2021-10-21 11:44 ` [PATCH v3 01/13] fs_parse: allow parameter value to be empty Lukas Czerner
2021-10-25 11:12 ` Carlos Maiolino
2021-10-21 11:44 ` [PATCH v3 02/13] ext4: Add fs parameter specifications for mount options Lukas Czerner
2021-10-21 11:44 ` [PATCH v3 03/13] ext4: move option validation to a separate function Lukas Czerner
2021-10-21 11:44 ` [PATCH v3 04/13] ext4: Change handle_mount_opt() to use fs_parameter Lukas Czerner
2021-10-21 11:45 ` [PATCH v3 05/13] ext4: Allow sb to be NULL in ext4_msg() Lukas Czerner
2021-10-21 11:45 ` [PATCH v3 06/13] ext4: move quota configuration out of handle_mount_opt() Lukas Czerner
2021-10-21 19:57 ` kernel test robot
2021-10-21 19:57 ` kernel test robot
2021-10-21 11:45 ` [PATCH v3 07/13] ext4: check ext2/3 compatibility outside handle_mount_opt() Lukas Czerner
2021-10-21 11:45 ` [PATCH v3 08/13] ext4: get rid of super block and sbi from handle_mount_ops() Lukas Czerner
2021-10-27 1:32 ` kernel test robot [this message]
2021-10-27 1:32 ` kernel test robot
2021-10-21 11:45 ` [PATCH v3 09/13] ext4: Completely separate options parsing and sb setup Lukas Czerner
2021-10-26 11:41 ` Carlos Maiolino
2021-10-21 11:45 ` [PATCH v3 10/13] ext4: clean up return values in handle_mount_opt() Lukas Czerner
2021-10-21 11:45 ` [PATCH v3 11/13] ext4: change token2str() to use ext4_param_specs Lukas Czerner
2021-10-26 11:40 ` Carlos Maiolino
2021-10-26 12:09 ` Lukas Czerner
2021-10-27 11:52 ` Lukas Czerner
2021-10-21 11:45 ` [PATCH v3 12/13] ext4: switch to the new mount api Lukas Czerner
2022-01-13 11:29 ` Jon Hunter
2022-01-13 12:08 ` Lukas Czerner
2022-01-13 15:06 ` Jon Hunter
2022-01-13 16:10 ` Jon Hunter
2022-01-14 9:40 ` Jon Hunter
2021-10-21 11:45 ` [PATCH v3 13/13] ext4: Remove unused match_table_t tokens Lukas Czerner
2021-10-26 11:39 ` [PATCH v3 00/13] ext4: new mount API conversion Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110270919.5evQEaqz-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.