From: Rob Herring <robh@kernel.org>
To: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Subject: [PATCH v12 2/5] perf: Add a counter for number of user access events in context
Date: Wed, 27 Oct 2021 15:16:38 -0500 [thread overview]
Message-ID: <20211027201641.2076427-3-robh@kernel.org> (raw)
In-Reply-To: <20211027201641.2076427-1-robh@kernel.org>
For controlling user space counter access, we need to know if any event
in a context (currently scheduled or not) is using user space counters.
Walking the context's list of events would be slow, so add a counter
to track this.
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
v10:
- Re-added.
- Maintain the count in the perf core
v9:
- Dropped
v8:
- new patch
---
include/linux/perf_event.h | 1 +
kernel/events/core.c | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 34ebcc9af608..d733cac749e2 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -828,6 +828,7 @@ struct perf_event_context {
int nr_events;
int nr_active;
+ int nr_user;
int is_active;
int nr_stat;
int nr_freq;
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 744e8726c5b2..01290d150da3 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -1808,6 +1808,8 @@ list_add_event(struct perf_event *event, struct perf_event_context *ctx)
list_add_rcu(&event->event_entry, &ctx->event_list);
ctx->nr_events++;
+ if (event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT)
+ ctx->nr_user++;
if (event->attr.inherit_stat)
ctx->nr_stat++;
@@ -1999,6 +2001,8 @@ list_del_event(struct perf_event *event, struct perf_event_context *ctx)
event->attach_state &= ~PERF_ATTACH_CONTEXT;
ctx->nr_events--;
+ if (event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT)
+ ctx->nr_user--;
if (event->attr.inherit_stat)
ctx->nr_stat--;
--
2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Subject: [PATCH v12 2/5] perf: Add a counter for number of user access events in context
Date: Wed, 27 Oct 2021 15:16:38 -0500 [thread overview]
Message-ID: <20211027201641.2076427-3-robh@kernel.org> (raw)
In-Reply-To: <20211027201641.2076427-1-robh@kernel.org>
For controlling user space counter access, we need to know if any event
in a context (currently scheduled or not) is using user space counters.
Walking the context's list of events would be slow, so add a counter
to track this.
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
v10:
- Re-added.
- Maintain the count in the perf core
v9:
- Dropped
v8:
- new patch
---
include/linux/perf_event.h | 1 +
kernel/events/core.c | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 34ebcc9af608..d733cac749e2 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -828,6 +828,7 @@ struct perf_event_context {
int nr_events;
int nr_active;
+ int nr_user;
int is_active;
int nr_stat;
int nr_freq;
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 744e8726c5b2..01290d150da3 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -1808,6 +1808,8 @@ list_add_event(struct perf_event *event, struct perf_event_context *ctx)
list_add_rcu(&event->event_entry, &ctx->event_list);
ctx->nr_events++;
+ if (event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT)
+ ctx->nr_user++;
if (event->attr.inherit_stat)
ctx->nr_stat++;
@@ -1999,6 +2001,8 @@ list_del_event(struct perf_event *event, struct perf_event_context *ctx)
event->attach_state &= ~PERF_ATTACH_CONTEXT;
ctx->nr_events--;
+ if (event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT)
+ ctx->nr_user--;
if (event->attr.inherit_stat)
ctx->nr_stat--;
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-27 20:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 20:16 [PATCH v12 0/5] Another version of arm64 userspace counter access support Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-10-27 20:16 ` [PATCH v12 1/5] x86: perf: Move RDPMC event flag to a common definition Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-11-30 22:51 ` Thomas Gleixner
2021-11-30 22:51 ` Thomas Gleixner
2021-10-27 20:16 ` Rob Herring [this message]
2021-10-27 20:16 ` [PATCH v12 2/5] perf: Add a counter for number of user access events in context Rob Herring
2021-11-30 22:57 ` Thomas Gleixner
2021-11-30 22:57 ` Thomas Gleixner
2021-12-03 15:58 ` Rob Herring
2021-12-03 15:58 ` Rob Herring
2021-12-04 14:23 ` Thomas Gleixner
2021-12-04 14:23 ` Thomas Gleixner
2021-10-27 20:16 ` [PATCH v12 3/5] arm64: perf: Add userspace counter access disable switch Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-10-27 20:16 ` [PATCH v12 4/5] arm64: perf: Enable PMU counter userspace access for perf event Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-10-27 20:16 ` [PATCH v12 5/5] Documentation: arm64: Document PMU counters access from userspace Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-11-15 16:57 ` [PATCH v12 0/5] Another version of arm64 userspace counter access support Rob Herring
2021-11-15 16:57 ` Rob Herring
2021-11-30 21:56 ` Rob Herring
2021-11-30 21:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027201641.2076427-3-robh@kernel.org \
--to=robh@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.