All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] xfs: fix err_cast.cocci warnings
Date: Fri, 29 Oct 2021 04:29:33 +0800	[thread overview]
Message-ID: <20211028202933.GA105369@e2f4bfd2b83a> (raw)
In-Reply-To: <202110290410.yQP2PwdZ-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

From: kernel test robot <lkp@intel.com>

fs/xfs/scrub/xfbtree.c:234:9-16: WARNING: ERR_CAST can be used with xfbt -> xfile


 Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))

Generated by: scripts/coccinelle/api/err_cast.cocci

Fixes: f47d10306ea7 ("xfs: connect in-memory btrees to xfiles")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git repair-rmap-live
head:   058725b83f3ab866a225aec3bfa204c0b7f4d3a8
commit: f47d10306ea759e3e0749de65cdd1680383be13f [326/331] xfs: connect in-memory btrees to xfiles
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago

 xfbtree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/xfs/scrub/xfbtree.c
+++ b/fs/xfs/scrub/xfbtree.c
@@ -231,7 +231,7 @@ xfbtree_create(
 
 	xfbt->xfile = xfile_create(description, 0);
 	if (IS_ERR(xfbt->xfile))
-		return ERR_PTR(PTR_ERR(xfbt->xfile));
+		return ERR_CAST(xfbt->xfile);
 
 	xfbt->target = xfs_alloc_memory_buftarg(mp, xfbt->xfile);
 	if (!xfbt->target) {

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: kbuild-all@lists.01.org,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] xfs: fix err_cast.cocci warnings
Date: Fri, 29 Oct 2021 04:29:33 +0800	[thread overview]
Message-ID: <20211028202933.GA105369@e2f4bfd2b83a> (raw)
In-Reply-To: <202110290410.yQP2PwdZ-lkp@intel.com>

From: kernel test robot <lkp@intel.com>

fs/xfs/scrub/xfbtree.c:234:9-16: WARNING: ERR_CAST can be used with xfbt -> xfile


 Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))

Generated by: scripts/coccinelle/api/err_cast.cocci

Fixes: f47d10306ea7 ("xfs: connect in-memory btrees to xfiles")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git repair-rmap-live
head:   058725b83f3ab866a225aec3bfa204c0b7f4d3a8
commit: f47d10306ea759e3e0749de65cdd1680383be13f [326/331] xfs: connect in-memory btrees to xfiles
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago

 xfbtree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/xfs/scrub/xfbtree.c
+++ b/fs/xfs/scrub/xfbtree.c
@@ -231,7 +231,7 @@ xfbtree_create(
 
 	xfbt->xfile = xfile_create(description, 0);
 	if (IS_ERR(xfbt->xfile))
-		return ERR_PTR(PTR_ERR(xfbt->xfile));
+		return ERR_CAST(xfbt->xfile);
 
 	xfbt->target = xfs_alloc_memory_buftarg(mp, xfbt->xfile);
 	if (!xfbt->target) {

  reply	other threads:[~2021-10-28 20:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 20:29 [djwong-xfs:repair-rmap-live 326/331] fs/xfs/scrub/xfbtree.c:234:9-16: WARNING: ERR_CAST can be used with xfbt -> xfile kernel test robot
2021-10-28 20:29 ` kernel test robot
2021-10-28 20:29 ` kernel test robot [this message]
2021-10-28 20:29   ` [PATCH] xfs: fix err_cast.cocci warnings kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028202933.GA105369@e2f4bfd2b83a \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.