All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: cgel.zte@gmail.com
Cc: dyoung@redhat.com, kexec@lists.infradead.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	rppt@linux.ibm.com, vgoyal@redhat.com, ye.guojin@zte.com.cn,
	zealci@zte.com.cn
Subject: Re: [PATCH v2] crash_dump: remove duplicate include in crash_dump.h
Date: Fri, 29 Oct 2021 17:28:30 +0800	[thread overview]
Message-ID: <20211029092830.GJ27625@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20211020090659.1038877-1-ye.guojin@zte.com.cn>

On 10/20/21 at 09:06am, cgel.zte@gmail.com wrote:
> From: Ye Guojin <ye.guojin@zte.com.cn>
> 
> In crash_dump.h, header file <linux/pgtable.h> is included twice. This
> duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
> after introduction of linux/pgtable.h") where the order of the header
> files is adjusted, while the old one was not removed.
> 
> Clean it up here.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Acked-by: Baoquan He <bhe@redhat.com>
> Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>

Thanks, add Andrew to CC.

> ---
> v2:
> - update the commit log
> ---
>  include/linux/crash_dump.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..b7b255b23b99 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
>  #include <linux/pgtable.h>
>  #include <uapi/linux/vmcore.h>
> 
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
>  /* For IS_ENABLED(CONFIG_CRASH_DUMP) */
>  #define ELFCORE_ADDR_MAX       (-1ULL)
>  #define ELFCORE_ADDR_ERR       (-2ULL)
> -- 
> 2.25.1
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: cgel.zte@gmail.com
Cc: dyoung@redhat.com, kexec@lists.infradead.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	rppt@linux.ibm.com, vgoyal@redhat.com, ye.guojin@zte.com.cn,
	zealci@zte.com.cn
Subject: Re: [PATCH v2] crash_dump: remove duplicate include in crash_dump.h
Date: Fri, 29 Oct 2021 17:28:30 +0800	[thread overview]
Message-ID: <20211029092830.GJ27625@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20211020090659.1038877-1-ye.guojin@zte.com.cn>

On 10/20/21 at 09:06am, cgel.zte@gmail.com wrote:
> From: Ye Guojin <ye.guojin@zte.com.cn>
> 
> In crash_dump.h, header file <linux/pgtable.h> is included twice. This
> duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
> after introduction of linux/pgtable.h") where the order of the header
> files is adjusted, while the old one was not removed.
> 
> Clean it up here.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Acked-by: Baoquan He <bhe@redhat.com>
> Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>

Thanks, add Andrew to CC.

> ---
> v2:
> - update the commit log
> ---
>  include/linux/crash_dump.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..b7b255b23b99 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
>  #include <linux/pgtable.h>
>  #include <uapi/linux/vmcore.h>
> 
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
>  /* For IS_ENABLED(CONFIG_CRASH_DUMP) */
>  #define ELFCORE_ADDR_MAX       (-1ULL)
>  #define ELFCORE_ADDR_ERR       (-2ULL)
> -- 
> 2.25.1
> 


  reply	other threads:[~2021-10-29  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  1:23 [PATCH] crash_dump: remove duplicate include in crash_dump.h cgel.zte
2021-10-20  1:23 ` cgel.zte
2021-10-20  1:53 ` Baoquan He
2021-10-20  1:53   ` Baoquan He
2021-10-20  9:06   ` [PATCH v2] " cgel.zte
2021-10-20  9:06     ` cgel.zte
2021-10-29  9:28     ` Baoquan He [this message]
2021-10-29  9:28       ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211029092830.GJ27625@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgel.zte@gmail.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rppt@linux.ibm.com \
    --cc=vgoyal@redhat.com \
    --cc=ye.guojin@zte.com.cn \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.