From: "Darrick J. Wong" <djwong@kernel.org>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/3] generic: fix description or typo in head comment
Date: Fri, 29 Oct 2021 08:41:06 -0700 [thread overview]
Message-ID: <20211029154106.GR24282@magnolia> (raw)
In-Reply-To: <20211029065943.3556529-3-ruansy.fnst@fujitsu.com>
On Fri, Oct 29, 2021 at 02:59:42PM +0800, Shiyang Ruan wrote:
> 1. update description according to the current testcase
> 2. "an the end -> at the end"
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> ---
> tests/generic/155 | 3 +--
> tests/generic/269 | 2 +-
> tests/generic/270 | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tests/generic/155 b/tests/generic/155
> index 2fe7894a..13292fbb 100755
> --- a/tests/generic/155
> +++ b/tests/generic/155
> @@ -13,8 +13,7 @@
> # - CoW all the rest of the blocks of the copies
> # - Compare fs block usage to (2), (1), and (0)
> #
> -# The main difference from 834 is that we use zero range, directio, and
> -# mmap to mix things up a bit.
> +# The main difference from No. 154 is that we use zero range to execute CoW.
'The main difference from generic/154 is that...'
> #
> . ./common/preamble
> _begin_fstest auto quick clone zero
> diff --git a/tests/generic/269 b/tests/generic/269
> index d78b7463..60a07b44 100755
> --- a/tests/generic/269
> +++ b/tests/generic/269
> @@ -4,7 +4,7 @@
> #
> # FSQA Test No. 269
> #
> -# Run fsstress and ENSPC hitters in parallel, check fs consistency an the end
> +# Run fsstress and ENSPC hitters in parallel, check fs consistency at the end
ENOSPC, not ENSPC
> #
> . ./common/preamble
> _begin_fstest auto rw prealloc ioctl enospc stress
> diff --git a/tests/generic/270 b/tests/generic/270
> index 1fb5795a..35141e05 100755
> --- a/tests/generic/270
> +++ b/tests/generic/270
> @@ -5,7 +5,7 @@
> # FSQA Test No. 270
> #
> # Run fsstress and ENSPC hitters in parallel, check quota and
> -# fs consistency an the end
> +# fs consistency at the end
This looks good to me, assuming the lack of a period at the end of the
sentence doesn't bother anyone. Apparently that's the new style in this
'texting' thing I keep hearing about. ;)
--D
> #
> . ./common/preamble
> _begin_fstest auto quota rw prealloc ioctl enospc stress
> --
> 2.33.0
>
>
>
next prev parent reply other threads:[~2021-10-29 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 6:59 [PATCH 0/3] Random fixes for generic Shiyang Ruan
2021-10-29 6:59 ` [PATCH 1/3] generic/138,139,140: fix the name for check file Shiyang Ruan
2021-10-29 15:48 ` Darrick J. Wong
2021-10-29 6:59 ` [PATCH 2/3] generic: fix description or typo in head comment Shiyang Ruan
2021-10-29 7:59 ` [PATCH v1.1 " Shiyang Ruan
2021-10-29 15:41 ` Darrick J. Wong [this message]
2021-10-29 6:59 ` [PATCH 3/3] generic/201: fix the description Shiyang Ruan
2021-10-29 15:41 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029154106.GR24282@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.