All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 3/3] generic/201: fix the description
Date: Fri, 29 Oct 2021 08:41:46 -0700	[thread overview]
Message-ID: <20211029154146.GS24282@magnolia> (raw)
In-Reply-To: <20211029065943.3556529-4-ruansy.fnst@fujitsu.com>

On Fri, Oct 29, 2021 at 02:59:43PM +0800, Shiyang Ruan wrote:
> This case is test for 'unlink', and there is no umount operation here.
> 
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>

Thanks for fixing this

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/generic/201     | 2 +-
>  tests/generic/201.out | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/201 b/tests/generic/201
> index 9b65445a..2598b44a 100755
> --- a/tests/generic/201
> +++ b/tests/generic/201
> @@ -50,7 +50,7 @@ md5sum $testdir/file1 | _filter_scratch
>  md5sum $testdir/file3 | _filter_scratch
>  md5sum $testdir/file3.chk | _filter_scratch
>  
> -echo "CoW and unmount"
> +echo "CoW and unlink"
>  cowoff=$((filesize / 4))
>  cowsz=$((filesize / 2))
>  $XFS_IO_PROG -f -c "pwrite -S 0x63 -b $cowsz $cowoff $cowsz" $testdir/file3 >> $seqres.full
> diff --git a/tests/generic/201.out b/tests/generic/201.out
> index 52669d27..6867704a 100644
> --- a/tests/generic/201.out
> +++ b/tests/generic/201.out
> @@ -5,4 +5,4 @@ Compare files
>  bdbcf02ee0aa977795a79d25fcfdccb1  SCRATCH_MNT/test-201/file1
>  d3959a68638c50af07f0258e032cb554  SCRATCH_MNT/test-201/file3
>  d3959a68638c50af07f0258e032cb554  SCRATCH_MNT/test-201/file3.chk
> -CoW and unmount
> +CoW and unlink
> -- 
> 2.33.0
> 
> 
> 

      reply	other threads:[~2021-10-29 15:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29  6:59 [PATCH 0/3] Random fixes for generic Shiyang Ruan
2021-10-29  6:59 ` [PATCH 1/3] generic/138,139,140: fix the name for check file Shiyang Ruan
2021-10-29 15:48   ` Darrick J. Wong
2021-10-29  6:59 ` [PATCH 2/3] generic: fix description or typo in head comment Shiyang Ruan
2021-10-29  7:59   ` [PATCH v1.1 " Shiyang Ruan
2021-10-29 15:41   ` [PATCH " Darrick J. Wong
2021-10-29  6:59 ` [PATCH 3/3] generic/201: fix the description Shiyang Ruan
2021-10-29 15:41   ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211029154146.GS24282@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=ruansy.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.