Re: [PATCH mptcp net-next v2] Support for IP_TOS for MPTCP setsockopt()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2669 bytes --]

Hi Poorva,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Poorva-Sonparote/Support-for-IP_TOS-for-MPTCP-setsockopt/20211027-004553
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 36d935a0a67e4456bd84943319718448c9647675
config: riscv-buildonly-randconfig-r004-20211031 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 82ed106567063ea269c6d5669278b733e173a42f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/d5f0751cd6aa8cc9cbd7ce6cc11e39106127098e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Poorva-Sonparote/Support-for-IP_TOS-for-MPTCP-setsockopt/20211027-004553
        git checkout d5f0751cd6aa8cc9cbd7ce6cc11e39106127098e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> net/mptcp/sockopt.c:624:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
           return ret;
                  ^~~
   net/mptcp/sockopt.c:606:9: note: initialize the variable 'ret' to silence this warning
           int ret, val;
                  ^
                   = 0
   1 error generated.


vim +/ret +624 net/mptcp/sockopt.c

   600	
   601	static int mptcp_setsockopt_v4_set_tos(struct mptcp_sock *msk, int optname,
   602					       sockptr_t optval, unsigned int optlen)
   603	{
   604		struct mptcp_subflow_context *subflow;
   605		struct sock *sk = (struct sock *)msk;
   606		int ret, val;
   607		int err;
   608	
   609		err = ip_setsockopt(sk, SOL_IP, optname, optval, optlen);
   610	
   611		if (err != 0)
   612			return err;
   613	
   614		lock_sock(sk);
   615		sockopt_seq_inc(msk);
   616		val = inet_sk(sk)->tos;
   617		mptcp_for_each_subflow(msk, subflow) {
   618			struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
   619	
   620			__ip_sock_set_tos(ssk, val);
   621		}
   622		release_sock(sk);
   623	
 > 624		return ret;
   625	}
   626	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35962 bytes --]