All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] mtd: core: protect access to MTD devices while in suspend
Date: Mon, 1 Nov 2021 08:40:59 +0100	[thread overview]
Message-ID: <20211101084059.5b703b8b@collabora.com> (raw)
In-Reply-To: <20211026055551.3053598-4-sean@geanix.com>

On Tue, 26 Oct 2021 07:55:50 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> @@ -1406,6 +1423,7 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
>  		    const u_char *buf)
>  {
>  	struct mtd_info *master = mtd_get_master(mtd);
> +	int ret;
>  
>  	*retlen = 0;
>  	if (!master->_panic_write)
> @@ -1419,8 +1437,12 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
>  	if (!master->oops_panic_write)
>  		master->oops_panic_write = true;
>  
> -	return master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> -				    retlen, buf);
> +	mtd_start_access(master);
> +	ret = master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> +				   retlen, buf);
> +	mtd_end_access(master);
> +
> +	return ret;
>  }

I suspect panic_write should be an exception, otherwise a panic in the
suspend path would never be able to write its data to the flash.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] mtd: core: protect access to MTD devices while in suspend
Date: Mon, 1 Nov 2021 08:40:59 +0100	[thread overview]
Message-ID: <20211101084059.5b703b8b@collabora.com> (raw)
In-Reply-To: <20211026055551.3053598-4-sean@geanix.com>

On Tue, 26 Oct 2021 07:55:50 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> @@ -1406,6 +1423,7 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
>  		    const u_char *buf)
>  {
>  	struct mtd_info *master = mtd_get_master(mtd);
> +	int ret;
>  
>  	*retlen = 0;
>  	if (!master->_panic_write)
> @@ -1419,8 +1437,12 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
>  	if (!master->oops_panic_write)
>  		master->oops_panic_write = true;
>  
> -	return master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> -				    retlen, buf);
> +	mtd_start_access(master);
> +	ret = master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> +				   retlen, buf);
> +	mtd_end_access(master);
> +
> +	return ret;
>  }

I suspect panic_write should be an exception, otherwise a panic in the
suspend path would never be able to write its data to the flash.

  reply	other threads:[~2021-11-01  7:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  5:55 [PATCH v4 0/4] mtd: core: protect access to mtd devices while in suspend Sean Nyekjaer
2021-10-26  5:55 ` Sean Nyekjaer
2021-10-26  5:55 ` [PATCH v4 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Sean Nyekjaer
2021-10-26  5:55   ` Sean Nyekjaer
2021-11-01  7:38   ` Boris Brezillon
2021-11-01  7:38     ` Boris Brezillon
2021-11-01  8:46     ` Sean Nyekjaer
2021-11-01  8:46       ` Sean Nyekjaer
2021-11-02  8:43       ` Boris Brezillon
2021-11-02  8:43         ` Boris Brezillon
2021-10-26  5:55 ` [PATCH v4 2/4] mtd: mtdconcat: don't use mtd_{suspend,resume}() Sean Nyekjaer
2021-10-26  5:55   ` Sean Nyekjaer
2021-10-26  5:55 ` [PATCH v4 3/4] mtd: core: protect access to MTD devices while in suspend Sean Nyekjaer
2021-10-26  5:55   ` Sean Nyekjaer
2021-11-01  7:40   ` Boris Brezillon [this message]
2021-11-01  7:40     ` Boris Brezillon
2021-10-26  5:55 ` [PATCH v4 4/4] mtd: rawnand: remove suspended check Sean Nyekjaer
2021-10-26  5:55   ` Sean Nyekjaer
2021-11-01  7:46 ` [PATCH v4 0/4] mtd: core: protect access to mtd devices while in suspend Boris Brezillon
2021-11-01  7:46   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211101084059.5b703b8b@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=bbrezillon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=sean@geanix.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.