From: kernel test robot <lkp@intel.com>
To: David Woodhouse <dwmw2@infradead.org>, kvm@vger.kernel.org
Cc: kbuild-all@lists.01.org, Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Joao Martins <joao.m.martins@oracle.com>,
Ankur Arora <ankur.a.arora@oracle.com>,
KarimAllah Raslan <karahmed@amazon.com>
Subject: Re: [PATCH v2 5/6] KVM: x86/xen: Maintain valid mapping of Xen shared_info page
Date: Tue, 2 Nov 2021 09:23:49 +0800 [thread overview]
Message-ID: <202111020957.1fml8KcC-lkp@intel.com> (raw)
In-Reply-To: <20211101190314.17954-6-dwmw2@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 4205 bytes --]
Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on mst-vhost/linux-next]
[also build test ERROR on linus/master v5.15 next-20211101]
[cannot apply to kvm/queue]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-Woodhouse/KVM-x86-xen-Add-in-kernel-Xen-event-channel-delivery/20211102-035038
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/bba9531e42e9dd7a2ab056057a94d56f43643e24
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-Woodhouse/KVM-x86-xen-Add-in-kernel-Xen-event-channel-delivery/20211102-035038
git checkout bba9531e42e9dd7a2ab056057a94d56f43643e24
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/dynamic_debug.h:6,
from include/linux/printk.h:555,
from include/linux/kernel.h:19,
from include/linux/cpumask.h:10,
from include/linux/mm_types_task.h:14,
from include/linux/mm_types.h:5,
from arch/x86/kvm/irq.h:13,
from arch/x86/kvm/mmu/mmu.c:18:
arch/x86/kvm/mmu/mmu.c: In function 'kvm_unmap_gfn_range':
>> arch/x86/kvm/mmu/mmu.c:1592:30: error: 'kvm_xen_enabled' undeclared (first use in this function); did you mean 'kvm_xen_msr_enabled'?
1592 | if (static_branch_unlikely(&kvm_xen_enabled.key)) {
| ^~~~~~~~~~~~~~~
include/linux/jump_label.h:496:43: note: in definition of macro 'static_branch_unlikely'
496 | if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
| ^
arch/x86/kvm/mmu/mmu.c:1592:30: note: each undeclared identifier is reported only once for each function it appears in
1592 | if (static_branch_unlikely(&kvm_xen_enabled.key)) {
| ^~~~~~~~~~~~~~~
include/linux/jump_label.h:496:43: note: in definition of macro 'static_branch_unlikely'
496 | if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
| ^
vim +1592 arch/x86/kvm/mmu/mmu.c
1587
1588 bool kvm_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range)
1589 {
1590 bool flush = false;
1591
> 1592 if (static_branch_unlikely(&kvm_xen_enabled.key)) {
1593 write_lock(&kvm->arch.xen.shinfo_lock);
1594
1595 if (kvm->arch.xen.shared_info &&
1596 kvm->arch.xen.shinfo_gfn >= range->start &&
1597 kvm->arch.xen.shinfo_cache.gfn < range->end) {
1598 /*
1599 * If kvm_xen_shared_info_init() had *finished* mapping the
1600 * page and assigned the pointer for real, then mark the page
1601 * dirty now instead of via the eventual cache teardown.
1602 */
1603 if (kvm->arch.xen.shared_info != KVM_UNMAPPED_PAGE) {
1604 kvm_set_pfn_dirty(kvm->arch.xen.shinfo_cache.pfn);
1605 kvm->arch.xen.shinfo_cache.dirty = false;
1606 }
1607
1608 kvm->arch.xen.shared_info = NULL;
1609 }
1610
1611 write_unlock(&kvm->arch.xen.shinfo_lock);
1612 }
1613
1614 if (kvm_memslots_have_rmaps(kvm))
1615 flush = kvm_handle_gfn_range(kvm, range, kvm_unmap_rmapp);
1616
1617 if (is_tdp_mmu_enabled(kvm))
1618 flush |= kvm_tdp_mmu_unmap_gfn_range(kvm, range, flush);
1619
1620 return flush;
1621 }
1622
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34096 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 5/6] KVM: x86/xen: Maintain valid mapping of Xen shared_info page
Date: Tue, 02 Nov 2021 09:23:49 +0800 [thread overview]
Message-ID: <202111020957.1fml8KcC-lkp@intel.com> (raw)
In-Reply-To: <20211101190314.17954-6-dwmw2@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 4301 bytes --]
Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on mst-vhost/linux-next]
[also build test ERROR on linus/master v5.15 next-20211101]
[cannot apply to kvm/queue]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-Woodhouse/KVM-x86-xen-Add-in-kernel-Xen-event-channel-delivery/20211102-035038
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/bba9531e42e9dd7a2ab056057a94d56f43643e24
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-Woodhouse/KVM-x86-xen-Add-in-kernel-Xen-event-channel-delivery/20211102-035038
git checkout bba9531e42e9dd7a2ab056057a94d56f43643e24
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/dynamic_debug.h:6,
from include/linux/printk.h:555,
from include/linux/kernel.h:19,
from include/linux/cpumask.h:10,
from include/linux/mm_types_task.h:14,
from include/linux/mm_types.h:5,
from arch/x86/kvm/irq.h:13,
from arch/x86/kvm/mmu/mmu.c:18:
arch/x86/kvm/mmu/mmu.c: In function 'kvm_unmap_gfn_range':
>> arch/x86/kvm/mmu/mmu.c:1592:30: error: 'kvm_xen_enabled' undeclared (first use in this function); did you mean 'kvm_xen_msr_enabled'?
1592 | if (static_branch_unlikely(&kvm_xen_enabled.key)) {
| ^~~~~~~~~~~~~~~
include/linux/jump_label.h:496:43: note: in definition of macro 'static_branch_unlikely'
496 | if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
| ^
arch/x86/kvm/mmu/mmu.c:1592:30: note: each undeclared identifier is reported only once for each function it appears in
1592 | if (static_branch_unlikely(&kvm_xen_enabled.key)) {
| ^~~~~~~~~~~~~~~
include/linux/jump_label.h:496:43: note: in definition of macro 'static_branch_unlikely'
496 | if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
| ^
vim +1592 arch/x86/kvm/mmu/mmu.c
1587
1588 bool kvm_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range)
1589 {
1590 bool flush = false;
1591
> 1592 if (static_branch_unlikely(&kvm_xen_enabled.key)) {
1593 write_lock(&kvm->arch.xen.shinfo_lock);
1594
1595 if (kvm->arch.xen.shared_info &&
1596 kvm->arch.xen.shinfo_gfn >= range->start &&
1597 kvm->arch.xen.shinfo_cache.gfn < range->end) {
1598 /*
1599 * If kvm_xen_shared_info_init() had *finished* mapping the
1600 * page and assigned the pointer for real, then mark the page
1601 * dirty now instead of via the eventual cache teardown.
1602 */
1603 if (kvm->arch.xen.shared_info != KVM_UNMAPPED_PAGE) {
1604 kvm_set_pfn_dirty(kvm->arch.xen.shinfo_cache.pfn);
1605 kvm->arch.xen.shinfo_cache.dirty = false;
1606 }
1607
1608 kvm->arch.xen.shared_info = NULL;
1609 }
1610
1611 write_unlock(&kvm->arch.xen.shinfo_lock);
1612 }
1613
1614 if (kvm_memslots_have_rmaps(kvm))
1615 flush = kvm_handle_gfn_range(kvm, range, kvm_unmap_rmapp);
1616
1617 if (is_tdp_mmu_enabled(kvm))
1618 flush |= kvm_tdp_mmu_unmap_gfn_range(kvm, range, flush);
1619
1620 return flush;
1621 }
1622
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34096 bytes --]
next prev parent reply other threads:[~2021-11-02 1:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 19:03 [PATCH v2 0/6] KVM: x86/xen: Add in-kernel Xen event channel delivery David Woodhouse
2021-11-01 19:03 ` [PATCH v2 1/6] KVM: x86/xen: Fix get_attr of KVM_XEN_ATTR_TYPE_SHARED_INFO David Woodhouse
2021-11-01 19:03 ` [PATCH v2 2/6] KVM: selftests: Add event channel upcall support to xen_shinfo_test David Woodhouse
2021-11-01 19:03 ` [PATCH v2 3/6] KVM: x86/xen: Use sizeof_field() instead of open-coding it David Woodhouse
2021-11-01 19:03 ` [PATCH v2 4/6] KVM: Fix kvm_map_gfn()/kvm_unmap_gfn() to take a kvm as their names imply David Woodhouse
2021-11-02 3:12 ` kernel test robot
2021-11-02 3:12 ` kernel test robot
2021-11-02 22:33 ` kernel test robot
2021-11-02 22:33 ` kernel test robot
2021-11-01 19:03 ` [PATCH v2 5/6] KVM: x86/xen: Maintain valid mapping of Xen shared_info page David Woodhouse
2021-11-02 1:23 ` kernel test robot [this message]
2021-11-02 1:23 ` kernel test robot
2021-11-04 19:05 ` David Woodhouse
2021-11-01 19:03 ` [PATCH v2 6/6] KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery David Woodhouse
2021-11-02 0:25 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111020957.1fml8KcC-lkp@intel.com \
--to=lkp@intel.com \
--cc=ankur.a.arora@oracle.com \
--cc=dwmw2@infradead.org \
--cc=jmattson@google.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=karahmed@amazon.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.