From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: [PATCH v2 0/1] vhost: Fix last queue index of devices with no cvq
Date: Tue, 2 Nov 2021 12:40:58 +0100 [thread overview]
Message-ID: <20211102114059.1917341-1-eperezma@redhat.com> (raw)
The -1 assumes that all devices with no cvq have an spare vq allocated
for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid
device by the standard, so just stick to the right number of device
models.
This is not a problem to vhost-net, but it is to vhost-vdpa, which
device model trust to reach the last index to finish starting the
device.
Tested with vp_vdpa with host's vhost=on and vhost=off.
v2:
* Delete all the conditional code instead of ROUND_DOWN in a
deinitely too-bit-tricky way.
Eugenio Pérez (1):
vhost: Fix last queue index of devices with no cvq
hw/net/vhost_net.c | 4 ----
1 file changed, 4 deletions(-)
--
2.27.0
next reply other threads:[~2021-11-02 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 11:40 Eugenio Pérez [this message]
2021-11-02 11:40 ` [PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq Eugenio Pérez
2021-11-02 14:09 ` Juan Quintela
2021-11-03 2:50 ` Jason Wang
2021-11-03 7:39 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102114059.1917341-1-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.