From: Juan Quintela <quintela@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq
Date: Tue, 02 Nov 2021 15:09:07 +0100 [thread overview]
Message-ID: <87k0hqk5to.fsf@secure.mitica> (raw)
In-Reply-To: <20211102114059.1917341-2-eperezma@redhat.com> ("Eugenio Pérez"'s message of "Tue, 2 Nov 2021 12:40:59 +0100")
Eugenio Pérez <eperezma@redhat.com> wrote:
Y> The -1 assumes that all devices with no cvq have an spare vq allocated
> for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid
> device by the standard, so just stick to the right number of device
> models.
>
> This is not a problem to vhost-net, but it is to vhost-vdpa, which
> device model trust to reach the last index to finish starting the
> device.
>
> Tested with vp_vdpa with host's vhost=on and vhost=off.
>
> Fixes: 049eb15b5fc9 ("vhost: record the last virtqueue index for the
> virtio device")
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Much clearer, thanks.
next prev parent reply other threads:[~2021-11-02 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 11:40 [PATCH v2 0/1] vhost: Fix last queue index of devices with no cvq Eugenio Pérez
2021-11-02 11:40 ` [PATCH v2 1/1] " Eugenio Pérez
2021-11-02 14:09 ` Juan Quintela [this message]
2021-11-03 2:50 ` Jason Wang
2021-11-03 7:39 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0hqk5to.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.