From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: Frank Earl <linusti@gmail.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
Konrad Weihmann <kweihmann@outlook.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/2] fetch/git: Handle github dropping git:// support
Date: Tue, 2 Nov 2021 15:57:41 +0100 [thread overview]
Message-ID: <20211102145741.inxodrxjabwiu67t@fedora> (raw)
In-Reply-To: <CANepkxCNovifgi84YiXmoydUpQbTLoV-uGWVF_oJ6rp10+V4cA@mail.gmail.com>
Hi Frank,
On Tue, Nov 02, 2021 at 09:06:19AM -0500, Frank Earl wrote:
> (Reply to all, since I simply hit reply...not nearly enough caffeine
> yet...)
>
> This kind of breaks other things- what if you have a server that you need
> to do protocol=ssh and it's authenticated (We have some of this at Motorola
I think in that case you have ;protocol=ssh at the end of your URL?
In that case, the suggested code does handle that because it only
replaces the protocol from git to https. git protocol does not have
authentication, c.f. man git-clone:
"""
The native transport (i.e. git:// URL) does no authentication and should be used with caution on unsecured
networks.
"""
So if you needed authentication in the first place and it worked, I'm
pretty sure this change will not change anything for you.
Hopefully I understood your complain and am not completely off-topic :)
Cheers,
Quentin
next prev parent reply other threads:[~2021-11-02 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 12:44 [PATCH 1/2] fetch/git: Handle github dropping git:// support Richard Purdie
2021-11-02 12:45 ` [PATCH 2/2] fetch/git: Show warning for invalid github urls Richard Purdie
2021-11-02 13:19 ` [bitbake-devel] [PATCH 1/2] fetch/git: Handle github dropping git:// support Konrad Weihmann
2021-11-02 13:27 ` Richard Purdie
2021-11-02 14:06 ` Frank Earl
2021-11-02 14:57 ` Quentin Schulz [this message]
2021-11-02 14:51 ` Jan-Simon Moeller
2021-11-02 18:00 ` Peter Kjellerstedt
[not found] <16B3BB5E65837842.31260@lists.openembedded.org>
2021-11-03 14:13 ` Richard Purdie
2021-11-09 15:40 ` gabriel.valcazar
2021-11-09 15:44 ` [bitbake-devel] " Alexander Kanavin
2021-11-09 15:47 ` Martin Jansa
2021-11-10 15:15 ` gabriel.valcazar
2021-11-11 11:03 ` [bitbake-devel] " Richard Purdie
2021-11-11 12:18 ` gabriel.valcazar
2021-11-11 12:27 ` [bitbake-devel] " Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102145741.inxodrxjabwiu67t@fedora \
--to=quentin.schulz@theobroma-systems.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=kweihmann@outlook.com \
--cc=linusti@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.