Re: [bitbake-devel] [PATCH 1/2] fetch/git: Handle github dropping git:// support

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2021-11-02 at 14:19 +0100, Konrad Weihmann wrote:
> 
> On 02.11.21 13:44, Richard Purdie wrote:
> > github is dropping support for git procotol iun git urls. Add code to remap
> > this to https in a way that could be used in older bitbake versions.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >   lib/bb/fetch2/git.py | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py
> > index e974445fbe..f5be24d6ab 100644
> > --- a/lib/bb/fetch2/git.py
> > +++ b/lib/bb/fetch2/git.py
> > @@ -142,6 +142,10 @@ class Git(FetchMethod):
> >               ud.proto = 'file'
> >           else:
> >               ud.proto = "git"
> > +        if ud.host == "github.com" and ud.proto == "git":
> > +            # github stopped supporting git protocol
> > +            # https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git
> 
> While having a warning within the bitbake is something very much 
> appreciated, I don't think it's a good idea to remap to https here, as I 
> think rather the recipes that still use this should be fixed.
> This will just lead to non-core layer (the ones being not so well 
> maintained) just ignoring the warning and leave the original offending 
> recipes as they are.
> 
> I think this solution does scale very well.
> For instance this assumes that github.com is used, but I can also think 
> of DNS aliases, where this rule here simply won't catch up... same for 
> the fact that other hosting platforms will likely go in the same 
> direction and we would end up with an ever growing condition here
> 
> Bottom line: I like the warning, but would rather insist on the recipes 
> that still use git:// + protocol=git to be fixed - at the mentioned 
> 11.1.22 likely fetching them will fail with an explicit error message 
> anyway, so I actually don't see the need to magically fix up things here

With 15 years of legacy branches and recipes out there, this change is intended
to be backported to older bitbakes to at least give some support to people stuck
on older versions. This is why this commit and the warning are separated.

The warning is being added as we're not at 11.1.22 yet and people have
previously said they don't like instant hard breaking error messages. We'll
therefore give people some time to update, then change master to an error.

Cheers,

Richard