All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [PATCH v3 0/2] vhost: Fix last queue index of devices with no cvq
Date: Wed,  3 Nov 2021 11:01:29 +0100	[thread overview]
Message-ID: <20211103100131.1983272-1-eperezma@redhat.com> (raw)

The -1 assumes that all devices with no cvq have an spare vq allocated
for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid
device by the standard, so just stick to the right number of device
models.

This is not a problem to vhost-net, but it is to vhost-vdpa, which
device model trust to reach the last index to finish starting the
device.

Tested with vp_vdpa with host's vhost=on and vhost=off.

v3:
* Recover cvq devices.
* Rename last_index to last_vq_index

v2:
* Delete all the conditional code instead of ROUND_DOWN in a
  deinitely too-bit-tricky way.

Eugenio Pérez (2):
  vhost: Rename last_index to last_vq_index
  vhost: Fix last vq queue index of devices with no cvq

 include/hw/virtio/vhost.h | 2 +-
 hw/net/vhost_net.c        | 8 ++++----
 hw/virtio/vhost-vdpa.c    | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.27.0




             reply	other threads:[~2021-11-03 10:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 10:01 Eugenio Pérez [this message]
2021-11-03 10:01 ` [PATCH v3 1/2] vhost: Rename last_index to last_vq_index Eugenio Pérez
2021-11-03 10:56   ` Juan Quintela
2021-11-04  2:45   ` Jason Wang
2021-11-03 10:01 ` [PATCH v3 2/2] vhost: Fix last vq queue index of devices with no cvq Eugenio Pérez
2021-11-03 10:55   ` Juan Quintela
2021-11-04  2:47   ` Jason Wang
2021-11-04  6:34     ` Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103100131.1983272-1-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.