From: Juan Quintela <quintela@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3 2/2] vhost: Fix last vq queue index of devices with no cvq
Date: Wed, 03 Nov 2021 11:55:51 +0100 [thread overview]
Message-ID: <87k0hp7bk8.fsf@secure.mitica> (raw)
In-Reply-To: <20211103100131.1983272-3-eperezma@redhat.com> ("Eugenio Pérez"'s message of "Wed, 3 Nov 2021 11:01:31 +0100")
Eugenio Pérez <eperezma@redhat.com> wrote:
> The -1 assumes that last index counts all vhost device models as having
> two queues, but they count only the ones that models the data queues.
>
> Because of that, the right change in last_index is to actually add the
> cvq, not to remove the missing one.
>
> This is not a problem to vhost-net, but it is to vhost-vdpa, which
> device model trust to reach the last index to finish starting the
> device.
>
> Tested with vp_vdpa with host's vhost=on and vhost=off, with ctrl_vq=on
> and ctrl_vq=off.
>
> Fixes: 049eb15b5fc9 ("vhost: record the last virtqueue index for the
> virtio device")
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2021-11-03 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 10:01 [PATCH v3 0/2] vhost: Fix last queue index of devices with no cvq Eugenio Pérez
2021-11-03 10:01 ` [PATCH v3 1/2] vhost: Rename last_index to last_vq_index Eugenio Pérez
2021-11-03 10:56 ` Juan Quintela
2021-11-04 2:45 ` Jason Wang
2021-11-03 10:01 ` [PATCH v3 2/2] vhost: Fix last vq queue index of devices with no cvq Eugenio Pérez
2021-11-03 10:55 ` Juan Quintela [this message]
2021-11-04 2:47 ` Jason Wang
2021-11-04 6:34 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0hp7bk8.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.