All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Alistair Francis <alistair@alistair23.me>, linux-kernel@vger.kernel.org
Subject: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency
Date: Wed,  3 Nov 2021 14:04:26 -0500	[thread overview]
Message-ID: <20211103190426.1511507-1-tyhicks@linux.microsoft.com> (raw)

Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
linker error:

 ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
 simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
 make: *** [Makefile:1187: vmlinux] Error 1

Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
Cc: stable@vger.kernel.org # 5.15.x
Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index ca0edab91aeb..d2f345245538 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1194,6 +1194,7 @@ config MFD_SI476X_CORE
 config MFD_SIMPLE_MFD_I2C
 	tristate
 	depends on I2C
+	select MFD_CORE
 	select REGMAP_I2C
 	help
 	  This driver creates a single register map with the intention for it
-- 
2.25.1


             reply	other threads:[~2021-11-03 19:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 19:04 Tyler Hicks [this message]
2021-11-03 21:58 ` [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency Alistair
2021-11-04  8:24 ` Lee Jones
2021-11-04 13:53   ` Tyler Hicks
2021-11-04 14:00     ` Robert Marko
2021-11-04 14:08       ` Lee Jones
2021-11-04 14:09         ` Robert Marko
2021-11-04 14:10       ` Tyler Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103190426.1511507-1-tyhicks@linux.microsoft.com \
    --to=tyhicks@linux.microsoft.com \
    --cc=alistair@alistair23.me \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.