From: Lee Jones <lee.jones@linaro.org>
To: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: Alistair Francis <alistair@alistair23.me>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency
Date: Thu, 4 Nov 2021 08:24:28 +0000 [thread overview]
Message-ID: <YYOYvDnX7yA932re@google.com> (raw)
In-Reply-To: <20211103190426.1511507-1-tyhicks@linux.microsoft.com>
On Wed, 03 Nov 2021, Tyler Hicks wrote:
> Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> linker error:
>
> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> make: *** [Makefile:1187: vmlinux] Error 1
>
> Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> Cc: stable@vger.kernel.org # 5.15.x
> Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Looks like the same change that has already been applied.
Could you rebase on top of the MFD tree please?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-11-04 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 19:04 [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency Tyler Hicks
2021-11-03 21:58 ` Alistair
2021-11-04 8:24 ` Lee Jones [this message]
2021-11-04 13:53 ` Tyler Hicks
2021-11-04 14:00 ` Robert Marko
2021-11-04 14:08 ` Lee Jones
2021-11-04 14:09 ` Robert Marko
2021-11-04 14:10 ` Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYOYvDnX7yA932re@google.com \
--to=lee.jones@linaro.org \
--cc=alistair@alistair23.me \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.