From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] utils/getdeveloperlib.py: fix check_output() return value decoding
Date: Wed, 3 Nov 2021 22:53:58 +0100 [thread overview]
Message-ID: <20211103225358.00d638d8@windsurf> (raw)
In-Reply-To: <87k0hpkkjl.fsf@dell.be.48ers.dk>
On Wed, 03 Nov 2021 22:15:42 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>
> > In Python 3.x, check_output() returns a "bytes" array, and not a
> > string. Its result needs to be decoded to be turned into a
> > string. Without this fix, "get-developers -c" bails out with:
>
> > Traceback (most recent call last):
> > File "/home/thomas/projets/buildroot/./utils/get-developers", line 105, in <module>
> > __main__()
> > File "/home/thomas/projets/buildroot/./utils/get-developers", line 53, in __main__
> > files = getdeveloperlib.check_developers(devs)
> > File "/home/thomas/projets/buildroot/utils/getdeveloperlib.py", line 280, in check_developers
> > files = subprocess.check_output(cmd).strip().split("\n")
> > TypeError: a bytes-like object is required, not 'str'
>
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> Alternatively we could use universal_newlines=True, but Ok - Committed
> to 2021.02.x and 2021.08.x, thanks.
But was this committed to master already? It seems not. Isn't it
dangerous to start committing stuff to stable branches that are not in
master? I thought you were only cherry-picking stuff from master.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-03 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 22:20 [Buildroot] [PATCH 1/2] utils/getdeveloperlib.py: fix check_output() return value decoding Thomas Petazzoni
2021-11-02 22:20 ` [Buildroot] [PATCH 2/2] utils/getdeveloperlib.py: call Developer.hasfile() with relative path Thomas Petazzoni
2021-11-03 21:15 ` Peter Korsgaard
2021-11-03 21:15 ` [Buildroot] [PATCH 1/2] utils/getdeveloperlib.py: fix check_output() return value decoding Peter Korsgaard
2021-11-03 21:53 ` Thomas Petazzoni [this message]
2021-11-03 22:10 ` Peter Korsgaard
2021-11-03 22:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103225358.00d638d8@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.