From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] utils/getdeveloperlib.py: call Developer.hasfile() with relative path
Date: Wed, 03 Nov 2021 22:15:47 +0100 [thread overview]
Message-ID: <87fssdkkjg.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211102222035.719508-2-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Tue, 2 Nov 2021 23:20:34 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> In commit
> 40bb37bd70d46822e803aaa5169dee8ff8b51093 ("utils/getdeveloperlib.py:
> use relative paths for files"), the Developer class was changed to use
> relative paths, including for its .hasfile() method.
> However the check_developers() function of getdeveloperlib.py was not
> updated accordingly, and continued to pass absolute paths. This caused
> "get-developers -c" to return the entire list of files in Buildroot as
> being unmaintained, as none of them were matching the file listed in
> the DEVELOPERS file.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-03 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 22:20 [Buildroot] [PATCH 1/2] utils/getdeveloperlib.py: fix check_output() return value decoding Thomas Petazzoni
2021-11-02 22:20 ` [Buildroot] [PATCH 2/2] utils/getdeveloperlib.py: call Developer.hasfile() with relative path Thomas Petazzoni
2021-11-03 21:15 ` Peter Korsgaard [this message]
2021-11-03 21:15 ` [Buildroot] [PATCH 1/2] utils/getdeveloperlib.py: fix check_output() return value decoding Peter Korsgaard
2021-11-03 21:53 ` Thomas Petazzoni
2021-11-03 22:10 ` Peter Korsgaard
2021-11-03 22:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fssdkkjg.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.