From: Segher Boessenkool <segher@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: sxwjean@gmail.com, aneesh.kumar@linux.ibm.com,
Zeal Robot <zealci@zte.com.cn>,
davidcomponentone@gmail.com, linux-kernel@vger.kernel.org,
nathan@kernel.org, yang.guang5@zte.com.cn, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: use swap() to make code cleaner
Date: Thu, 4 Nov 2021 06:33:51 -0500 [thread overview]
Message-ID: <20211104113351.GK614@gate.crashing.org> (raw)
In-Reply-To: <20211104210637.3c424bcc@elm.ozlabs.ibm.com>
On Thu, Nov 04, 2021 at 09:06:56PM +1100, Stephen Rothwell wrote:
> On Thu, 4 Nov 2021 14:17:09 +0800 davidcomponentone@gmail.com wrote:
> > From: Yang Guang <yang.guang5@zte.com.cn>
> >
> > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> > opencoding it.
>
> So if swap() is in the above include file, then you should include it.
It is included from kernel.h already (which is included from delay.h).
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: davidcomponentone@gmail.com, sxwjean@gmail.com,
Zeal Robot <zealci@zte.com.cn>,
linux-kernel@vger.kernel.org, nathan@kernel.org,
yang.guang5@zte.com.cn, paulus@samba.org,
aneesh.kumar@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: use swap() to make code cleaner
Date: Thu, 4 Nov 2021 06:33:51 -0500 [thread overview]
Message-ID: <20211104113351.GK614@gate.crashing.org> (raw)
In-Reply-To: <20211104210637.3c424bcc@elm.ozlabs.ibm.com>
On Thu, Nov 04, 2021 at 09:06:56PM +1100, Stephen Rothwell wrote:
> On Thu, 4 Nov 2021 14:17:09 +0800 davidcomponentone@gmail.com wrote:
> > From: Yang Guang <yang.guang5@zte.com.cn>
> >
> > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> > opencoding it.
>
> So if swap() is in the above include file, then you should include it.
It is included from kernel.h already (which is included from delay.h).
Segher
next prev parent reply other threads:[~2021-11-04 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 6:17 [PATCH] powerpc: use swap() to make code cleaner davidcomponentone
2021-11-04 6:17 ` davidcomponentone
2021-11-04 10:06 ` Stephen Rothwell
2021-11-04 10:06 ` Stephen Rothwell
2021-11-04 11:33 ` Segher Boessenkool [this message]
2021-11-04 11:33 ` Segher Boessenkool
2021-11-04 20:26 ` Stephen Rothwell
2021-11-04 20:26 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2021-12-18 1:59 davidcomponentone
2021-12-18 1:59 ` davidcomponentone
2021-12-26 21:52 ` Michael Ellerman
2021-12-26 21:52 ` Michael Ellerman
2021-11-04 1:09 davidcomponentone
2021-11-04 1:09 ` davidcomponentone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104113351.GK614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=davidcomponentone@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathan@kernel.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
--cc=sxwjean@gmail.com \
--cc=yang.guang5@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.