All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: will@kernel.org, arnd@kernel.org, catalin.marinas@arm.com,
	gregkh@linuxfoundation.org, anshuman.khandual@arm.com,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] arm64: cpufeature: Export this_cpu_has_cap helper
Date: Thu, 4 Nov 2021 10:50:32 -0600	[thread overview]
Message-ID: <20211104165032.GA491267@p14s> (raw)
In-Reply-To: <20211103221256.725080-1-suzuki.poulose@arm.com>

On Wed, Nov 03, 2021 at 10:12:56PM +0000, Suzuki K Poulose wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Export the this_cpu_has_cap() for use by modules. This is
> used by TRBE driver. Without this patch, TRBE will fail
> to build as a module :
> 
> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
> 
> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [ change to EXPORT_SYMBOL_GPL ]
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>  arch/arm64/kernel/cpufeature.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index f8a3067d10c6..82e68c69bb99 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2839,6 +2839,7 @@ bool this_cpu_has_cap(unsigned int n)
>  
>  	return false;
>  }
> +EXPORT_SYMBOL_GPL(this_cpu_has_cap);
>

I have applied this patch.

Thanks
Mathieu

>  /*
>   * This helper function is used in a narrow window when,
> -- 
> 2.25.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: will@kernel.org, arnd@kernel.org, catalin.marinas@arm.com,
	gregkh@linuxfoundation.org, anshuman.khandual@arm.com,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] arm64: cpufeature: Export this_cpu_has_cap helper
Date: Thu, 4 Nov 2021 10:50:32 -0600	[thread overview]
Message-ID: <20211104165032.GA491267@p14s> (raw)
In-Reply-To: <20211103221256.725080-1-suzuki.poulose@arm.com>

On Wed, Nov 03, 2021 at 10:12:56PM +0000, Suzuki K Poulose wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Export the this_cpu_has_cap() for use by modules. This is
> used by TRBE driver. Without this patch, TRBE will fail
> to build as a module :
> 
> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
> 
> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [ change to EXPORT_SYMBOL_GPL ]
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>  arch/arm64/kernel/cpufeature.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index f8a3067d10c6..82e68c69bb99 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2839,6 +2839,7 @@ bool this_cpu_has_cap(unsigned int n)
>  
>  	return false;
>  }
> +EXPORT_SYMBOL_GPL(this_cpu_has_cap);
>

I have applied this patch.

Thanks
Mathieu

>  /*
>   * This helper function is used in a narrow window when,
> -- 
> 2.25.4
> 

  reply	other threads:[~2021-11-04 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 22:12 [PATCH] arm64: cpufeature: Export this_cpu_has_cap helper Suzuki K Poulose
2021-11-03 22:12 ` Suzuki K Poulose
2021-11-04 16:50 ` Mathieu Poirier [this message]
2021-11-04 16:50   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104165032.GA491267@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=anshuman.khandual@arm.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.