Re: [RFC][PATCH v4 1/2] trace: Add trace any kernel object

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4049 bytes --]

Hi Jeff,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.15 next-20211104]
[cannot apply to tip/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jeff-Xie/trace-Add-trace-any-kernel-object/20211101-231428
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
config: i386-buildonly-randconfig-r002-20211101 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 264d3b6d4e08401c5b50a85bd76e80b3461d77e6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5c8589956ecad7f8aeec51f42e6b9012d38be7f7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jeff-Xie/trace-Add-trace-any-kernel-object/20211101-231428
        git checkout 5c8589956ecad7f8aeec51f42e6b9012d38be7f7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_object.c:445:6: error: no previous prototype for function 'unregister_object_trigger' [-Werror,-Wmissing-prototypes]
   void unregister_object_trigger(char *glob, struct event_trigger_ops *ops,
        ^
   kernel/trace/trace_object.c:445:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void unregister_object_trigger(char *glob, struct event_trigger_ops *ops,
   ^
   static 
>> kernel/trace/trace_object.c:689:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
           if (WARN_ON_ONCE(atomic_read(&trace_object_ref) <= 0))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/asm-generic/bug.h:103:33: note: expanded from macro 'WARN_ON_ONCE'
   #define WARN_ON_ONCE(condition) ({                              \
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/trace/trace_object.c:704:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   kernel/trace/trace_object.c:689:2: note: remove the 'if' if its condition is always false
           if (WARN_ON_ONCE(atomic_read(&trace_object_ref) <= 0))
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/trace/trace_object.c:687:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   2 errors generated.


vim +/unregister_object_trigger +445 kernel/trace/trace_object.c

   444	
 > 445	void unregister_object_trigger(char *glob, struct event_trigger_ops *ops,
   446				       struct event_trigger_data *test,
   447				       struct trace_event_file *file)
   448	{
   449		struct event_trigger_data *data;
   450		bool unregistered = false;
   451	
   452		lockdep_assert_held(&event_mutex);
   453	
   454		list_for_each_entry(data, &file->triggers, list) {
   455			if (data->cmd_ops->trigger_type == test->cmd_ops->trigger_type) {
   456				unregistered = true;
   457				list_del_rcu(&data->list);
   458				trace_event_trigger_enable_disable(file, 0);
   459				update_cond_flag(file);
   460				break;
   461			}
   462		}
   463	
   464		if (unregistered && data->ops->free) {
   465			data->ops->free(data->ops, data);
   466			exit_trace_object();
   467		}
   468	}
   469	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41980 bytes --]