Re: [PATCH 6/7] net: dsa: b53: Add logic for TX timestamping

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4159 bytes --]

Hi Martin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master next-20211105]
[cannot apply to tip/timers/core v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Martin-Kaistra/Add-PTP-support-for-BCM53128-switch/20211104-213538
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 84882cf72cd774cf16fd338bdbf00f69ac9f9194
config: x86_64-randconfig-r033-20211105 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 847a6807332b13f43704327c2d30103ec0347c77)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b484f272339c8b2fd87f5d3493849439003c0026
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Martin-Kaistra/Add-PTP-support-for-BCM53128-switch/20211104-213538
        git checkout b484f272339c8b2fd87f5d3493849439003c0026
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/dsa/b53/b53_common.c:2304:20: error: incompatible function pointer types initializing 'void (*)(struct dsa_switch *, int, struct sk_buff *)' with an expression of type 'bool (struct dsa_switch *, int, struct sk_buff *)' (aka '_Bool (struct dsa_switch *, int, struct sk_buff *)') [-Werror,-Wincompatible-function-pointer-types]
           .port_txtstamp          = b53_port_txtstamp,
                                     ^~~~~~~~~~~~~~~~~
   1 error generated.


vim +2304 drivers/net/dsa/b53/b53_common.c

  2262	
  2263	static const struct dsa_switch_ops b53_switch_ops = {
  2264		.get_tag_protocol	= b53_get_tag_protocol,
  2265		.setup			= b53_setup,
  2266		.teardown		= b53_teardown,
  2267		.get_strings		= b53_get_strings,
  2268		.get_ethtool_stats	= b53_get_ethtool_stats,
  2269		.get_sset_count		= b53_get_sset_count,
  2270		.get_ethtool_phy_stats	= b53_get_ethtool_phy_stats,
  2271		.phy_read		= b53_phy_read16,
  2272		.phy_write		= b53_phy_write16,
  2273		.adjust_link		= b53_adjust_link,
  2274		.phylink_validate	= b53_phylink_validate,
  2275		.phylink_mac_link_state	= b53_phylink_mac_link_state,
  2276		.phylink_mac_config	= b53_phylink_mac_config,
  2277		.phylink_mac_an_restart	= b53_phylink_mac_an_restart,
  2278		.phylink_mac_link_down	= b53_phylink_mac_link_down,
  2279		.phylink_mac_link_up	= b53_phylink_mac_link_up,
  2280		.port_enable		= b53_enable_port,
  2281		.port_disable		= b53_disable_port,
  2282		.get_mac_eee		= b53_get_mac_eee,
  2283		.set_mac_eee		= b53_set_mac_eee,
  2284		.port_bridge_join	= b53_br_join,
  2285		.port_bridge_leave	= b53_br_leave,
  2286		.port_pre_bridge_flags	= b53_br_flags_pre,
  2287		.port_bridge_flags	= b53_br_flags,
  2288		.port_stp_state_set	= b53_br_set_stp_state,
  2289		.port_fast_age		= b53_br_fast_age,
  2290		.port_vlan_filtering	= b53_vlan_filtering,
  2291		.port_vlan_add		= b53_vlan_add,
  2292		.port_vlan_del		= b53_vlan_del,
  2293		.port_fdb_dump		= b53_fdb_dump,
  2294		.port_fdb_add		= b53_fdb_add,
  2295		.port_fdb_del		= b53_fdb_del,
  2296		.port_mirror_add	= b53_mirror_add,
  2297		.port_mirror_del	= b53_mirror_del,
  2298		.port_mdb_add		= b53_mdb_add,
  2299		.port_mdb_del		= b53_mdb_del,
  2300		.port_max_mtu		= b53_get_max_mtu,
  2301		.port_change_mtu	= b53_change_mtu,
  2302		.get_ts_info		= b53_get_ts_info,
  2303		.port_rxtstamp		= b53_port_rxtstamp,
> 2304		.port_txtstamp		= b53_port_txtstamp,
  2305	};
  2306	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37420 bytes --]