From: Chris Morgan <macroalpha82@gmail.com>
To: u-boot@lists.denx.de
Cc: sjg@chromium.org, eugen.hristev@microchip.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH] w1: w1-gpio: Loosen timings to improve cold boot reliability
Date: Mon, 8 Nov 2021 09:07:16 -0600 [thread overview]
Message-ID: <20211108150716.59-1-macroalpha82@gmail.com> (raw)
From: Chris Morgan <macromorgan@hotmail.com>
On my NTC CHIP whenever I do a cold boot any attached DIPs cannot be
found. Rebooting on the other hand appears to fix the issue. I found
that if I modified the timing slightly (but still within spec) the
w1 identification on cold boot became far more reliable.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/w1/w1-gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/w1/w1-gpio.c b/drivers/w1/w1-gpio.c
index 9346f810ce..5565de2a92 100644
--- a/drivers/w1/w1-gpio.c
+++ b/drivers/w1/w1-gpio.c
@@ -22,8 +22,8 @@
#define W1_TIMING_E 9
#define W1_TIMING_F 55
#define W1_TIMING_G 0
-#define W1_TIMING_H 480
-#define W1_TIMING_I 70
+#define W1_TIMING_H 600
+#define W1_TIMING_I 100
#define W1_TIMING_J 410
struct w1_gpio_pdata {
--
2.30.2
next reply other threads:[~2021-11-08 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 15:07 Chris Morgan [this message]
2021-11-08 16:14 ` [PATCH] w1: w1-gpio: Loosen timings to improve cold boot reliability Eugen.Hristev
2021-11-22 11:16 ` Eugen.Hristev
2021-11-30 15:46 ` Chris Morgan
2021-12-09 8:27 ` Eugen.Hristev
2022-04-26 6:49 ` Eugen.Hristev
2022-05-05 15:49 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108150716.59-1-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=eugen.hristev@microchip.com \
--cc=macromorgan@hotmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.