From: Christoph Hellwig <hch@lst.de>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Zhi Wang <zhi.wang.linux@gmail.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, jgg@nvidia.com,
intel-gvt-dev@lists.freedesktop.org, hch@lst.de
Subject: Re: [Intel-gfx] [PATCH 1/3] i915/gvt: seperate tracked MMIO table from handlers.c
Date: Tue, 9 Nov 2021 08:51:00 +0100 [thread overview]
Message-ID: <20211109075100.GA27284@lst.de> (raw)
In-Reply-To: <875yt17qzs.fsf@intel.com>
On Tue, Nov 09, 2021 at 09:00:39AM +0200, Jani Nikula wrote:
> On Mon, 08 Nov 2021, Zhi Wang <zhi.wang.linux@gmail.com> wrote:
> > From: Zhi Wang <zhi.wang.linux@gmail.com>
> >
> > To support the new mdev interfaces and the re-factor patches from
> > Christoph, which moves the GVT-g code into a dedicated module, the GVT-g
> > MMIO snapshot still needs to be saved in i915 so that the inital clean HW
> > state can be used for the further vGPU. Seperate the tracked MMIO table
> > from GVT-g, so that GVT-g and i915 can both use it.
>
> Do you really have to both put code in a header and then include that in
> multiple places?
>
> I think you may need to rethink the whole approach, maybe make them
> actual tables instead of code.
Without understanding this code too well: an approach that makes in
actual table and uses an accessor seems more useful to me as well.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Zhi Wang <zhi.wang.linux@gmail.com>,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jgg@nvidia.com,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH 1/3] i915/gvt: seperate tracked MMIO table from handlers.c
Date: Tue, 9 Nov 2021 08:51:00 +0100 [thread overview]
Message-ID: <20211109075100.GA27284@lst.de> (raw)
In-Reply-To: <875yt17qzs.fsf@intel.com>
On Tue, Nov 09, 2021 at 09:00:39AM +0200, Jani Nikula wrote:
> On Mon, 08 Nov 2021, Zhi Wang <zhi.wang.linux@gmail.com> wrote:
> > From: Zhi Wang <zhi.wang.linux@gmail.com>
> >
> > To support the new mdev interfaces and the re-factor patches from
> > Christoph, which moves the GVT-g code into a dedicated module, the GVT-g
> > MMIO snapshot still needs to be saved in i915 so that the inital clean HW
> > state can be used for the further vGPU. Seperate the tracked MMIO table
> > from GVT-g, so that GVT-g and i915 can both use it.
>
> Do you really have to both put code in a header and then include that in
> multiple places?
>
> I think you may need to rethink the whole approach, maybe make them
> actual tables instead of code.
Without understanding this code too well: an approach that makes in
actual table and uses an accessor seems more useful to me as well.
next prev parent reply other threads:[~2021-11-09 7:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 21:27 [Intel-gfx] [PATCH 1/3] i915/gvt: seperate tracked MMIO table from handlers.c Zhi Wang
2021-11-08 21:27 ` Zhi Wang
2021-11-08 21:27 ` [Intel-gfx] [PATCH 2/3] i915/gvt: save the initial HW state snapshot in i915 Zhi Wang
2021-11-08 21:27 ` Zhi Wang
2021-11-08 21:27 ` [Intel-gfx] [PATCH 3/3] i915/gvt: Use the initial HW state snapshot saved " Zhi Wang
2021-11-08 21:27 ` Zhi Wang
2021-11-09 7:00 ` [Intel-gfx] [PATCH 1/3] i915/gvt: seperate tracked MMIO table from handlers.c Jani Nikula
2021-11-09 7:00 ` Jani Nikula
2021-11-09 7:51 ` Christoph Hellwig [this message]
2021-11-09 7:51 ` Christoph Hellwig
2021-11-09 8:41 ` [Intel-gfx] " Wang, Zhi A
2021-11-09 8:41 ` Wang, Zhi A
2021-11-09 10:20 ` [Intel-gfx] " Jani Nikula
2021-11-09 10:20 ` Jani Nikula
2021-11-09 10:36 ` [Intel-gfx] " hch
2021-11-09 10:36 ` hch
2021-11-09 10:51 ` [Intel-gfx] " Wang, Zhi A
2021-11-09 10:51 ` Wang, Zhi A
2021-11-09 10:51 ` Wang, Zhi A
2021-11-09 10:58 ` [Intel-gfx] " hch
2021-11-09 10:58 ` hch
2021-11-09 11:02 ` [Intel-gfx] " Wang, Zhi A
2021-11-09 11:02 ` Wang, Zhi A
2021-11-09 11:02 ` Wang, Zhi A
2021-11-09 10:53 ` [Intel-gfx] " Wang, Zhi A
2021-11-09 10:53 ` Wang, Zhi A
2021-11-09 9:44 ` [Intel-gfx] " Christoph Hellwig
2021-11-09 9:44 ` Christoph Hellwig
2021-11-09 14:33 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] " Patchwork
2021-11-11 23:32 ` [Intel-gfx] [PATCH 1/3] " kernel test robot
2021-11-11 23:32 ` kernel test robot
2021-11-11 23:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109075100.GA27284@lst.de \
--to=hch@lst.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.