All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: denali: Add the dependency on HAS_IOMEM
Date: Tue, 9 Nov 2021 14:28:28 +0100	[thread overview]
Message-ID: <20211109142828.3e4ec837@xps13> (raw)
In-Reply-To: <20211109125457.213-1-caihuoqing@baidu.com>

Hi Cai,

caihuoqing@baidu.com wrote on Tue, 9 Nov 2021 20:54:55 +0800:

> The helper function devm_platform_ioremap_resource_xxx()
> needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---

 Can you please add a Fixes tag?

>  drivers/mtd/nand/raw/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 67b7cb67c030..0a45d3c6c15b 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -26,7 +26,7 @@ config MTD_NAND_DENALI_PCI
>  config MTD_NAND_DENALI_DT
>  	tristate "Denali NAND controller as a DT device"
>  	select MTD_NAND_DENALI
> -	depends on HAS_DMA && HAVE_CLK && OF
> +	depends on HAS_DMA && HAVE_CLK && OF && HAS_IOMEM
>  	help
>  	  Enable the driver for NAND flash on platforms using a Denali NAND
>  	  controller as a DT device.


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: denali: Add the dependency on HAS_IOMEM
Date: Tue, 9 Nov 2021 14:28:28 +0100	[thread overview]
Message-ID: <20211109142828.3e4ec837@xps13> (raw)
In-Reply-To: <20211109125457.213-1-caihuoqing@baidu.com>

Hi Cai,

caihuoqing@baidu.com wrote on Tue, 9 Nov 2021 20:54:55 +0800:

> The helper function devm_platform_ioremap_resource_xxx()
> needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---

 Can you please add a Fixes tag?

>  drivers/mtd/nand/raw/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 67b7cb67c030..0a45d3c6c15b 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -26,7 +26,7 @@ config MTD_NAND_DENALI_PCI
>  config MTD_NAND_DENALI_DT
>  	tristate "Denali NAND controller as a DT device"
>  	select MTD_NAND_DENALI
> -	depends on HAS_DMA && HAVE_CLK && OF
> +	depends on HAS_DMA && HAVE_CLK && OF && HAS_IOMEM
>  	help
>  	  Enable the driver for NAND flash on platforms using a Denali NAND
>  	  controller as a DT device.


Thanks,
Miquèl

  reply	other threads:[~2021-11-09 13:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 12:54 [PATCH] mtd: rawnand: denali: Add the dependency on HAS_IOMEM Cai Huoqing
2021-11-09 12:54 ` Cai Huoqing
2021-11-09 13:28 ` Miquel Raynal [this message]
2021-11-09 13:28   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211109142828.3e4ec837@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=caihuoqing@baidu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.