From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [5.15 REGRESSION] iomap: Fix inline extent handling in iomap_readpage
Date: Wed, 10 Nov 2021 13:55:27 +0100 [thread overview]
Message-ID: <20211110125527.GA25465@lst.de> (raw)
In-Reply-To: <20211110113842.517426-1-agruenba@redhat.com>
On Wed, Nov 10, 2021 at 12:38:42PM +0100, Andreas Gruenbacher wrote:
> + if (iomap->type == IOMAP_INLINE) {
> + /*
> + * The filesystem sets iomap->length to the size of the inline
> + * data. We're at the end of the file, so we know that the
> + * rest of the page needs to be zeroed out.
> + */
> + iomap->length = iomap_read_inline_data(iter, page);
> + return iomap->length;
You can't just change iomap->length here. Fix the file system to
return the right length, please.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com, stable@vger.kernel.org
Subject: Re: [5.15 REGRESSION] iomap: Fix inline extent handling in iomap_readpage
Date: Wed, 10 Nov 2021 13:55:27 +0100 [thread overview]
Message-ID: <20211110125527.GA25465@lst.de> (raw)
In-Reply-To: <20211110113842.517426-1-agruenba@redhat.com>
On Wed, Nov 10, 2021 at 12:38:42PM +0100, Andreas Gruenbacher wrote:
> + if (iomap->type == IOMAP_INLINE) {
> + /*
> + * The filesystem sets iomap->length to the size of the inline
> + * data. We're at the end of the file, so we know that the
> + * rest of the page needs to be zeroed out.
> + */
> + iomap->length = iomap_read_inline_data(iter, page);
> + return iomap->length;
You can't just change iomap->length here. Fix the file system to
return the right length, please.
next prev parent reply other threads:[~2021-11-10 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 11:38 [Cluster-devel] [5.15 REGRESSION] iomap: Fix inline extent handling in iomap_readpage Andreas Gruenbacher
2021-11-10 11:38 ` Andreas Gruenbacher
2021-11-10 12:55 ` Christoph Hellwig [this message]
2021-11-10 12:55 ` Christoph Hellwig
2021-11-10 14:52 ` [Cluster-devel] " Andreas Gruenbacher
2021-11-10 14:52 ` Andreas Gruenbacher
2021-11-11 7:25 ` [Cluster-devel] " Christoph Hellwig
2021-11-11 7:25 ` Christoph Hellwig
2021-11-11 16:21 ` [Cluster-devel] " Andreas Grünbacher
2021-11-11 16:21 ` Andreas Grünbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110125527.GA25465@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.