All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] package/meson: disable meson wrap downloads
@ 2021-11-10 18:37 Yann E. MORIN
  2021-11-10 19:06 ` Peter Seiderer
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2021-11-10 18:37 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=12ba3563655e3ebab252e52daa6c710864fa869f
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

We don't want to allow meson to download wrap dependencies as this
bypasses buildroot's dependency resolution.

This is badly documented in the meson manual, but there is at least
an FAQ that refers to it:

    https://mesonbuild.com/FAQ.html#does-wrap-download-sources-behind-my-back

    Meson has a option called wrap-mode which can be used to disable
    wrap downloads altogether with --wrap-mode=nodownload.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
[yann.morin.1998@free.fr: add pointer to FAQ]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/meson/cross-compilation.conf.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
index 37b49eea3b..7a7ece97ae 100644
--- a/package/meson/cross-compilation.conf.in
+++ b/package/meson/cross-compilation.conf.in
@@ -17,6 +17,7 @@ c_args = [@TARGET_CFLAGS@]
 c_link_args = [@TARGET_LDFLAGS@]
 cpp_args = [@TARGET_CXXFLAGS@]
 cpp_link_args = [@TARGET_LDFLAGS@]
+wrap_mode = 'nodownload'
 
 [properties]
 needs_exe_wrapper = true
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [git commit] package/meson: disable meson wrap downloads
  2021-11-10 18:37 [Buildroot] [git commit] package/meson: disable meson wrap downloads Yann E. MORIN
@ 2021-11-10 19:06 ` Peter Seiderer
  2021-11-10 21:00   ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Seiderer @ 2021-11-10 19:06 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot

On Wed, 10 Nov 2021 19:37:34 +0100, Yann E. MORIN <yann.morin.1998@free.fr> wrote:

> commit: https://git.buildroot.net/buildroot/commit/?id=12ba3563655e3ebab252e52daa6c710864fa869f
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> We don't want to allow meson to download wrap dependencies as this
> bypasses buildroot's dependency resolution.
>
> This is badly documented in the meson manual, but there is at least
> an FAQ that refers to it:
>
>     https://mesonbuild.com/FAQ.html#does-wrap-download-sources-behind-my-back

https://mesonbuild.com/Subprojects.html#commandline-options

And [1] and [2] for some past time buildroot discussion on it...

Regards,
Peter

[1] http://lists.busybox.net/pipermail/buildroot/2019-December/572391.html
[2]http://lists.busybox.net/pipermail/buildroot/2019-December/572391.html

>
>     Meson has a option called wrap-mode which can be used to disable
>     wrap downloads altogether with --wrap-mode=nodownload.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> [yann.morin.1998@free.fr: add pointer to FAQ]
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
>  package/meson/cross-compilation.conf.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
> index 37b49eea3b..7a7ece97ae 100644
> --- a/package/meson/cross-compilation.conf.in
> +++ b/package/meson/cross-compilation.conf.in
> @@ -17,6 +17,7 @@ c_args = [@TARGET_CFLAGS@]
>  c_link_args = [@TARGET_LDFLAGS@]
>  cpp_args = [@TARGET_CXXFLAGS@]
>  cpp_link_args = [@TARGET_LDFLAGS@]
> +wrap_mode = 'nodownload'
>
>  [properties]
>  needs_exe_wrapper = true
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [git commit] package/meson: disable meson wrap downloads
  2021-11-10 19:06 ` Peter Seiderer
@ 2021-11-10 21:00   ` Yann E. MORIN
  0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-11-10 21:00 UTC (permalink / raw)
  To: Peter Seiderer; +Cc: buildroot

Peter, All,

On 2021-11-10 20:06 +0100, Peter Seiderer spake thusly:
> On Wed, 10 Nov 2021 19:37:34 +0100, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> 
> > commit: https://git.buildroot.net/buildroot/commit/?id=12ba3563655e3ebab252e52daa6c710864fa869f
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >
> > We don't want to allow meson to download wrap dependencies as this
> > bypasses buildroot's dependency resolution.
> >
> > This is badly documented in the meson manual, but there is at least
> > an FAQ that refers to it:
> >
> >     https://mesonbuild.com/FAQ.html#does-wrap-download-sources-behind-my-back
> 
> https://mesonbuild.com/Subprojects.html#commandline-options

Ah, so obvious! :-)

I tried both:
    https://mesonbuild.com/Wrap-dependency-system-manual.html
    https://mesonbuild.com/Commands.html

> And [1] and [2] for some past time buildroot discussion on it...

Ah, thanks for the reminder. That's too bad I did not spot a
corresponding patch on the list. ;-)

Regards,
Yann E. MORIN.

> Regards,
> Peter
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2019-December/572391.html
> [2]http://lists.busybox.net/pipermail/buildroot/2019-December/572391.html
> 
> >
> >     Meson has a option called wrap-mode which can be used to disable
> >     wrap downloads altogether with --wrap-mode=nodownload.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > [yann.morin.1998@free.fr: add pointer to FAQ]
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > ---
> >  package/meson/cross-compilation.conf.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
> > index 37b49eea3b..7a7ece97ae 100644
> > --- a/package/meson/cross-compilation.conf.in
> > +++ b/package/meson/cross-compilation.conf.in
> > @@ -17,6 +17,7 @@ c_args = [@TARGET_CFLAGS@]
> >  c_link_args = [@TARGET_LDFLAGS@]
> >  cpp_args = [@TARGET_CXXFLAGS@]
> >  cpp_link_args = [@TARGET_LDFLAGS@]
> > +wrap_mode = 'nodownload'
> >
> >  [properties]
> >  needs_exe_wrapper = true
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-10 21:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-10 18:37 [Buildroot] [git commit] package/meson: disable meson wrap downloads Yann E. MORIN
2021-11-10 19:06 ` Peter Seiderer
2021-11-10 21:00   ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.