All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports
Date: Thu, 11 Nov 2021 10:39:59 -0500	[thread overview]
Message-ID: <20211111103354-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20211111120905.ozy5iucoqjhhoc72@sirius.home.kraxel.org>

On Thu, Nov 11, 2021 at 01:09:05PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > When the acpihp driver is used the linux kernel will just call the aml
> > methods and I suspect the pci device will stay invisible then because
> > nobody flips the slot power control bit (with native-hotplug=on, for
> > native-hotplug=off this isn't a problem of course).
> 
> Hmm, on a quick smoke test with both patch series (mine + igors) applied
> everything seems to work fine on a quick glance.  Dunno why.  Maybe the
> pcieport driver turns on slot power even in case pciehp is not active.

Well power and hotplug capabilities are mostly unrelated, right?

> I still feel a bit nervous about trying the new "both pcie + acpi
> hotplug enabled" approach that close to the release date ...
> 
> take care,
>   Gerd

I feel switching to native so late would be inappropriate, looks more
like a feature than a bugfix. Given that - we need Igor's patches.
Given that - would you say I should apply yours? I'm inclined to
do so but if you prefer waiting until after the release I'll
defer to your judgement.

-- 
MST



  reply	other threads:[~2021-11-11 15:55 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 12:04 [PATCH 0/6] RfC: try improve native hotplug for pcie root ports Gerd Hoffmann
2021-10-11 12:04 ` [PATCH 1/6] pci: implement power state Gerd Hoffmann
2021-10-11 12:05 ` [PATCH 2/6] pcie: implement slow power control for pcie root ports Gerd Hoffmann
2021-10-11 12:05 ` [PATCH 3/6] pcie: add power indicator blink check Gerd Hoffmann
2021-11-15 11:29   ` Michael S. Tsirkin
2021-11-15 14:52     ` Gerd Hoffmann
2021-10-11 12:05 ` [PATCH 4/6] pcie: factor out pcie_cap_slot_unplug() Gerd Hoffmann
2021-10-11 12:05 ` [PATCH 5/6] pcie: fast unplug when slot power is off Gerd Hoffmann
2021-10-12  5:56   ` Michael S. Tsirkin
2021-10-12  6:46     ` Gerd Hoffmann
2021-10-11 12:05 ` [PATCH 6/6] pcie: expire pending delete Gerd Hoffmann
2021-10-11 12:49   ` Michael S. Tsirkin
2021-10-12  5:30     ` Gerd Hoffmann
2021-10-12  5:46       ` Michael S. Tsirkin
2021-10-12  6:44         ` Gerd Hoffmann
2021-10-12  7:01           ` Michael S. Tsirkin
2021-10-18 15:36 ` [PATCH 0/6] RfC: try improve native hotplug for pcie root ports Michael S. Tsirkin
2021-10-19  5:21   ` Gerd Hoffmann
2021-10-19  5:46     ` Michael S. Tsirkin
2021-10-19  6:29       ` Gerd Hoffmann
2021-11-01 21:47         ` Michael S. Tsirkin
2021-11-02 12:09           ` Gerd Hoffmann
2021-11-10 12:02 ` Michael S. Tsirkin
2021-11-11  7:53   ` Gerd Hoffmann
2021-11-11  8:20     ` Michael S. Tsirkin
2021-11-11  9:34       ` Gerd Hoffmann
2021-11-11 12:09         ` Gerd Hoffmann
2021-11-11 15:39           ` Michael S. Tsirkin [this message]
2021-11-12 11:15             ` Gerd Hoffmann
2021-11-12 12:17               ` Igor Mammedov
2021-11-15 11:13               ` Michael S. Tsirkin
2021-11-11  9:35       ` Daniel P. Berrangé
2021-11-11 17:11         ` Michael S. Tsirkin
2021-11-11 18:08           ` Daniel P. Berrangé
2021-11-11 18:43             ` Michael S. Tsirkin
2021-11-12 10:16               ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211111103354-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.