All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH/next v1] package/qt5declarative: move the qt5gui select from qt5declarative to qt5quick
@ 2021-11-14 13:57 Peter Seiderer
  2021-11-14 14:14 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Seiderer @ 2021-11-14 13:57 UTC (permalink / raw)
  To: buildroot
  Cc: Кузьминов Сергей,
	Julien Corjon

As requested/suggested by Sergey Kuzminov([1]) move the qt5gui select from
qt5declarative to qt5quick.

The qt5declarative (without qt5quick) compiles and installs fine without
qt5gui enabled and code inspection of the qt5declarative souce package *.pro
files shows the unconditionally gui dependencies only in for doc-snippets
and/or test projectes or real the qt5quick moduls.

[1] https://lore.kernel.org/buildroot/6fd05f97-7fb9-96d8-cca0-5063be8ad620@gmail.com

Reported-by: "Кузьминов Сергей" <kuzminov.sergey81@gmail.com>
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Notes:
  - @Sergey: I used the ASCII version of your name, hope it is o.k. for you?
---
 package/qt5/qt5declarative/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/qt5/qt5declarative/Config.in b/package/qt5/qt5declarative/Config.in
index 3ba9224c22..5ec83daa27 100644
--- a/package/qt5/qt5declarative/Config.in
+++ b/package/qt5/qt5declarative/Config.in
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_QT5DECLARATIVE
 	bool "qt5declarative"
 	depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
-	select BR2_PACKAGE_QT5BASE_GUI
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
@@ -16,6 +15,7 @@ if BR2_PACKAGE_QT5DECLARATIVE
 
 config BR2_PACKAGE_QT5DECLARATIVE_QUICK
 	bool "quick module"
+	select BR2_PACKAGE_QT5BASE_GUI
 	select BR2_PACKAGE_QT5BASE_OPENGL if BR2_PACKAGE_QT5_GL_AVAILABLE
 
 endif
-- 
2.33.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH/next v1] package/qt5declarative: move the qt5gui select from qt5declarative to qt5quick
  2021-11-14 13:57 [Buildroot] [PATCH/next v1] package/qt5declarative: move the qt5gui select from qt5declarative to qt5quick Peter Seiderer
@ 2021-11-14 14:14 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-11-14 14:14 UTC (permalink / raw)
  To: Peter Seiderer
  Cc: Кузьминов Сергей,
	Julien Corjon, buildroot

On Sun, 14 Nov 2021 14:57:22 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> As requested/suggested by Sergey Kuzminov([1]) move the qt5gui select from
> qt5declarative to qt5quick.
> 
> The qt5declarative (without qt5quick) compiles and installs fine without
> qt5gui enabled and code inspection of the qt5declarative souce package *.pro
> files shows the unconditionally gui dependencies only in for doc-snippets
> and/or test projectes or real the qt5quick moduls.
> 
> [1] https://lore.kernel.org/buildroot/6fd05f97-7fb9-96d8-cca0-5063be8ad620@gmail.com
> 
> Reported-by: "Кузьминов Сергей" <kuzminov.sergey81@gmail.com>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Notes:
>   - @Sergey: I used the ASCII version of your name, hope it is o.k. for you?
> ---
>  package/qt5/qt5declarative/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-14 14:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-14 13:57 [Buildroot] [PATCH/next v1] package/qt5declarative: move the qt5gui select from qt5declarative to qt5quick Peter Seiderer
2021-11-14 14:14 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.