From: Tom Rini <trini@konsulko.com>
To: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, aford173@gmail.com,
andre.przywara@arm.com, andrey.zhizhikin@leica-geosystems.com,
christianshewitt@gmail.com, festevam@gmail.com, hs@denx.de,
iliev@ronetix.at, jagan@amarulasolutions.com,
marcel.ziswiler@toradex.com, narmstrong@baylibre.com,
patrick.delaunay@foss.st.com, pbrobinson@gmail.com,
peng.fan@nxp.com, rick@andestech.com, sbabic@denx.de,
seanga2@gmail.com, sjg@chromium.org, t.remmet@phytec.de,
tharvey@gateworks.com
Subject: Re: [PATCH v2] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board
Date: Mon, 15 Nov 2021 16:28:41 -0500 [thread overview]
Message-ID: <20211115212841.GY24579@bill-the-cat> (raw)
In-Reply-To: <6ab89061-46eb-ef79-3133-a661f23101d1@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]
On Mon, Nov 15, 2021 at 06:27:08PM -0300, Ariel D'Alessandro wrote:
> Hi Tom,
>
> Thanks for the feedback.
>
> On 11/15/21 6:11 PM, Tom Rini wrote:
> > On Mon, Nov 15, 2021 at 05:24:22PM -0300, Ariel D'Alessandro wrote:
> >
> >> Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for:
> >>
> >> - 1GiB DDR4 RAM
> >> - 16 GiB eMMC
> >> - SD card
> >> - Gigabit ethernet
> >> - USBOTG1 peripheral - fastboot
> >>
> >> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
> >> ---
> >> MAINTAINERS | 8 +
> >
> > Typically this goes in to board/.../MAINTAINERS
>
> Will fix in v3.
>
> >
> >> arch/arm/dts/imx8mn-var-som.dts | 423 ++++++++++++++
> >
> > What linux kernel version (or, is it just in linux-next?) is this from?
>
> It's already supported in current linux/master:
>
> $ git describe origin/master
> v5.16-rc1-3-g8ab774587903
OK, good, thanks.
>
> >
> > [snip]
> >> +#ifdef CONFIG_SPL_BUILD
> >> +
> >> +#define CONFIG_SPL_STACK 0x980000
> >> +#define CONFIG_SPL_BSS_START_ADDR 0x950000
> >> +#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K
> >> +#define CONFIG_SYS_SPL_MALLOC_START 0x42200000
> >> +#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K
> >> +
> >> +/* For RAW image gives a error info not panic */
> >> +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE
> >> +
> >> +#endif /* CONFIG_SPL_BUILD */
> >
> > We can't guard CONFIG options with CONFIG_SPL_BUILD or
> > !CONFIG_SPL_BUILD.
>
> Sorry I don't understand, could you expand on the proper way to handle
> the above configuration? AFAICS, several imx8m boards follow this same
> pattern:
>
> $ git grep -l CONFIG_SPL_BUILD -- include/configs/imx8m*
> include/configs/imx8mm-cl-iot-gate.h
> include/configs/imx8mm_beacon.h
> include/configs/imx8mm_evk.h
> include/configs/imx8mm_icore_mx8mm.h
> include/configs/imx8mm_venice.h
> include/configs/imx8mn_beacon.h
> include/configs/imx8mn_evk.h
> include/configs/imx8mp_evk.h
> include/configs/imx8mq_cm.h
> include/configs/imx8mq_evk.h
> include/configs/imx8mq_phanbell.h
Yes, it's sadly a common anti-pattern. Just always define things.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-15 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 20:24 [PATCH v2] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board Ariel D'Alessandro
2021-11-15 21:11 ` Tom Rini
2021-11-15 21:27 ` Ariel D'Alessandro
2021-11-15 21:28 ` Tom Rini [this message]
2021-11-15 21:46 ` Ariel D'Alessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115212841.GY24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=aford173@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=ariel.dalessandro@collabora.com \
--cc=christianshewitt@gmail.com \
--cc=festevam@gmail.com \
--cc=hs@denx.de \
--cc=iliev@ronetix.at \
--cc=jagan@amarulasolutions.com \
--cc=marcel.ziswiler@toradex.com \
--cc=narmstrong@baylibre.com \
--cc=patrick.delaunay@foss.st.com \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=rick@andestech.com \
--cc=sbabic@denx.de \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=t.remmet@phytec.de \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.