All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Naveen Naidu <naveennaidu479@gmail.com>, bhelgaas@google.com
Cc: kbuild-all@lists.01.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 1/1] PCI: Add KUnit tests for __pci_read_base()
Date: Tue, 16 Nov 2021 02:18:58 +0800	[thread overview]
Message-ID: <202111160235.1ddh4Dkx-lkp@intel.com> (raw)
In-Reply-To: <950fd05e97d492a71eff54e2c0020d3ae9dd1c85.1636919579.git.naveennaidu479@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2445 bytes --]

Hi Naveen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: parisc-randconfig-c024-20211115 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/57b950c5684fcfff54e46f4369fd7f708a29ca60
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
        git checkout 57b950c5684fcfff54e46f4369fd7f708a29ca60
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/pci-read-base-test.c:538:6: warning: no previous prototype for 'set_test_data_type_1_headers' [-Wmissing-prototypes]
     538 | void set_test_data_type_1_headers(
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/set_test_data_type_1_headers +538 drivers/pci/pci-read-base-test.c

   537	
 > 538	void set_test_data_type_1_headers(
   539		const struct type_1_header_test_data test_data, struct resource *res)
   540	{
   541		res->start = 0;
   542		res->end = 0;
   543		res->flags = test_data.res_flags;
   544	
   545		type_1_header[BAR0].value = test_data.BAR0_value;
   546		type_1_header[BAR1].value = test_data.BAR1_value;
   547	
   548		type_1_BARS_config[config_BAR0].allocated_size =
   549			test_data.BAR0_allocated_size;
   550	
   551		type_1_BARS_config[config_BAR1].allocated_size =
   552			test_data.BAR1_allocated_size;
   553	
   554		init_registers();
   555	}
   556	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32126 bytes --]

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Naveen Naidu <naveennaidu479@gmail.com>, bhelgaas@google.com
Cc: kbuild-all@lists.01.org, Naveen Naidu <naveennaidu479@gmail.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	skhan@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/1] PCI: Add KUnit tests for __pci_read_base()
Date: Tue, 16 Nov 2021 02:18:58 +0800	[thread overview]
Message-ID: <202111160235.1ddh4Dkx-lkp@intel.com> (raw)
In-Reply-To: <950fd05e97d492a71eff54e2c0020d3ae9dd1c85.1636919579.git.naveennaidu479@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2445 bytes --]

Hi Naveen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: parisc-randconfig-c024-20211115 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/57b950c5684fcfff54e46f4369fd7f708a29ca60
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
        git checkout 57b950c5684fcfff54e46f4369fd7f708a29ca60
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/pci-read-base-test.c:538:6: warning: no previous prototype for 'set_test_data_type_1_headers' [-Wmissing-prototypes]
     538 | void set_test_data_type_1_headers(
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/set_test_data_type_1_headers +538 drivers/pci/pci-read-base-test.c

   537	
 > 538	void set_test_data_type_1_headers(
   539		const struct type_1_header_test_data test_data, struct resource *res)
   540	{
   541		res->start = 0;
   542		res->end = 0;
   543		res->flags = test_data.res_flags;
   544	
   545		type_1_header[BAR0].value = test_data.BAR0_value;
   546		type_1_header[BAR1].value = test_data.BAR1_value;
   547	
   548		type_1_BARS_config[config_BAR0].allocated_size =
   549			test_data.BAR0_allocated_size;
   550	
   551		type_1_BARS_config[config_BAR1].allocated_size =
   552			test_data.BAR1_allocated_size;
   553	
   554		init_registers();
   555	}
   556	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32126 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/1] PCI: Add KUnit tests for __pci_read_base()
Date: Tue, 16 Nov 2021 02:18:58 +0800	[thread overview]
Message-ID: <202111160235.1ddh4Dkx-lkp@intel.com> (raw)
In-Reply-To: <950fd05e97d492a71eff54e2c0020d3ae9dd1c85.1636919579.git.naveennaidu479@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2506 bytes --]

Hi Naveen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: parisc-randconfig-c024-20211115 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/57b950c5684fcfff54e46f4369fd7f708a29ca60
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
        git checkout 57b950c5684fcfff54e46f4369fd7f708a29ca60
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/pci-read-base-test.c:538:6: warning: no previous prototype for 'set_test_data_type_1_headers' [-Wmissing-prototypes]
     538 | void set_test_data_type_1_headers(
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/set_test_data_type_1_headers +538 drivers/pci/pci-read-base-test.c

   537	
 > 538	void set_test_data_type_1_headers(
   539		const struct type_1_header_test_data test_data, struct resource *res)
   540	{
   541		res->start = 0;
   542		res->end = 0;
   543		res->flags = test_data.res_flags;
   544	
   545		type_1_header[BAR0].value = test_data.BAR0_value;
   546		type_1_header[BAR1].value = test_data.BAR1_value;
   547	
   548		type_1_BARS_config[config_BAR0].allocated_size =
   549			test_data.BAR0_allocated_size;
   550	
   551		type_1_BARS_config[config_BAR1].allocated_size =
   552			test_data.BAR1_allocated_size;
   553	
   554		init_registers();
   555	}
   556	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32126 bytes --]

  parent reply	other threads:[~2021-11-15 18:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 20:08 [PATCH 0/1] PCI: Intial KUnit test fixture for resource assignment Naveen Naidu
2021-11-14 20:08 ` Naveen Naidu
2021-11-14 20:08 ` [PATCH 1/1] PCI: Add KUnit tests for __pci_read_base() Naveen Naidu
2021-11-14 20:08   ` Naveen Naidu
2021-11-15  5:12   ` kernel test robot
2021-11-15  5:12     ` kernel test robot
2021-11-15  5:12     ` kernel test robot
2021-11-15 18:18   ` kernel test robot [this message]
2021-11-15 18:18     ` kernel test robot
2021-11-15 18:18     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111160235.1ddh4Dkx-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bhelgaas@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=naveennaidu479@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.