All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
	o.rempel@pengutronix.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	linux-remoteproc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] remoteproc: coredump: correct argument 2 type for memcpy_fromio
Date: Tue, 16 Nov 2021 11:47:37 -0700	[thread overview]
Message-ID: <20211116184737.GA2324186@p14s> (raw)
In-Reply-To: <20211110032101.517487-1-peng.fan@oss.nxp.com>

Hi Peng,

On Wed, Nov 10, 2021 at 11:21:01AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Address the sparse check warning:
> >> drivers/remoteproc/remoteproc_coredump.c:169:53:
> sparse: warning: incorrect type in argument 2 (different address spaces)
> sparse:    expected void const volatile [noderef] __iomem *src
> sparse:    got void *[assigned] ptr
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/remoteproc/remoteproc_coredump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c
> index aee657cc08c6..f39c98aa1b49 100644
> --- a/drivers/remoteproc/remoteproc_coredump.c
> +++ b/drivers/remoteproc/remoteproc_coredump.c
> @@ -166,7 +166,7 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest,
>  			memset(dest, 0xff, size);
>  		} else {
>  			if (is_iomem)
> -				memcpy_fromio(dest, ptr, size);
> +				memcpy_fromio(dest, (void const __iomem *)ptr, size);

Shouldn't this be (const void __iomem *) to respect the signature in [1]?

[1]. https://elixir.bootlin.com/linux/latest/source/include/asm-generic/logic_io.h#L71

>  			else
>  				memcpy(dest, ptr, size);
>  		}
> -- 
> 2.25.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
	o.rempel@pengutronix.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	linux-remoteproc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] remoteproc: coredump: correct argument 2 type for memcpy_fromio
Date: Tue, 16 Nov 2021 11:47:37 -0700	[thread overview]
Message-ID: <20211116184737.GA2324186@p14s> (raw)
In-Reply-To: <20211110032101.517487-1-peng.fan@oss.nxp.com>

Hi Peng,

On Wed, Nov 10, 2021 at 11:21:01AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Address the sparse check warning:
> >> drivers/remoteproc/remoteproc_coredump.c:169:53:
> sparse: warning: incorrect type in argument 2 (different address spaces)
> sparse:    expected void const volatile [noderef] __iomem *src
> sparse:    got void *[assigned] ptr
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/remoteproc/remoteproc_coredump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c
> index aee657cc08c6..f39c98aa1b49 100644
> --- a/drivers/remoteproc/remoteproc_coredump.c
> +++ b/drivers/remoteproc/remoteproc_coredump.c
> @@ -166,7 +166,7 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest,
>  			memset(dest, 0xff, size);
>  		} else {
>  			if (is_iomem)
> -				memcpy_fromio(dest, ptr, size);
> +				memcpy_fromio(dest, (void const __iomem *)ptr, size);

Shouldn't this be (const void __iomem *) to respect the signature in [1]?

[1]. https://elixir.bootlin.com/linux/latest/source/include/asm-generic/logic_io.h#L71

>  			else
>  				memcpy(dest, ptr, size);
>  		}
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-11-16 18:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10  3:21 [PATCH] remoteproc: coredump: correct argument 2 type for memcpy_fromio Peng Fan (OSS)
2021-11-10  3:21 ` Peng Fan (OSS)
2021-11-16 18:47 ` Mathieu Poirier [this message]
2021-11-16 18:47   ` Mathieu Poirier
2021-11-17  3:34   ` Peng Fan
2021-11-17  3:34     ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116184737.GA2324186@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=o.rempel@pengutronix.de \
    --cc=ohad@wizery.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.