From: Mel Gorman <mgorman@suse.de>
To: Gang Li <ligang.bdlg@bytedance.com>
Cc: Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-api@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH v1] sched/numa: add per-process numa_balancing
Date: Thu, 18 Nov 2021 08:58:20 +0000 [thread overview]
Message-ID: <20211118085819.GD3301@suse.de> (raw)
In-Reply-To: <f0193837-2f2c-b55f-cd79-b80d931e7931@bytedance.com>
On Thu, Nov 18, 2021 at 11:26:30AM +0800, Gang Li wrote:
> On 11/17/21 6:10 PM, Mel Gorman wrote:
> > On Wed, Nov 17, 2021 at 05:38:28PM +0800, Gang Li wrote:
> > > If those APIs are ok with you, I will send v2 soon.
> > >
> > > 1. prctl(PR_NUMA_BALANCING, PR_SET_THP_DISABLE);
> >
> > It would be (PR_SET_NUMAB_DISABLE, 1)
> >
> > > 2. prctl(PR_NUMA_BALANCING, PR_SET_THP_ENABLE);
> >
> > An enable prctl will have the same problems as
> > prctl(PR_NUMA_BALANCING, PR_SET_NUMA_BALANCING, 0/1) -- it should have
> > meaning if the numa_balancing sysctl is disabled.
> >
> > > 3. prctl(PR_NUMA_BALANCING, PR_GET_THP);
> > >
> >
> > PR_GET_NUMAB_DISABLE
> >
>
> How about this:
>
> 1. prctl(PR_NUMA_BALANCING, PR_SET_NUMAB_DEFAULT); //follow global
> 2. prctl(PR_NUMA_BALANCING, PR_SET_NUMAB_DISABLE); //disable
> 3. prctl(PR_NUMA_BALANCING, PR_SET_NUMAB_ENABLE); //enable
If PR_SET_NUMAB_ENABLE enables numa balancing for a task when
kernel.numa_balancing == 0 instead of returning an error then sure.
> 4. prctl(PR_NUMA_BALANCING, PR_GET_NUMAB);
>
> PR_SET_NUMAB_DISABLE/ENABLE can always have meaning whether the
> numa_balancing sysctl is disabled or not,
>
> --
> Thanks,
> Gang Li
>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2021-11-18 8:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:26 [PATCH v1] sched/numa: add per-process numa_balancing Gang Li
2021-10-28 15:30 ` Mel Gorman
2021-10-29 6:12 ` Gang Li
2021-10-29 8:37 ` Mel Gorman
2021-11-09 8:28 ` 李港
2021-11-09 9:19 ` Mel Gorman
2021-11-09 10:40 ` Gang Li
2021-11-09 12:12 ` Mel Gorman
2021-11-09 13:58 ` Gang Li
2021-11-09 16:26 ` Mel Gorman
2021-11-17 7:07 ` Gang Li
2021-11-17 8:29 ` Mel Gorman
2021-11-17 9:38 ` Gang Li
2021-11-17 10:10 ` Mel Gorman
2021-11-18 3:26 ` Gang Li
2021-11-18 8:58 ` Mel Gorman [this message]
2021-11-18 9:49 ` Gang Li
2021-10-29 7:48 ` [External] " 李港
2021-11-22 7:34 ` Gang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118085819.GD3301@suse.de \
--to=mgorman@suse.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.