All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	David Sterba <dsterba@suse.com>,
	linux-doc@vger.kernel.org
Subject: fs/btrfs/zoned.c:1697: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Date: Thu, 18 Nov 2021 09:00:09 +0800	[thread overview]
Message-ID: <202111180903.CVuFf9Tz-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3446 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: afba2bc036b0ed983bef6bd7c00c827e97d1ba31 btrfs: zoned: implement active zone tracking
date:   3 weeks ago
config: m68k-randconfig-r004-20211109 (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=afba2bc036b0ed983bef6bd7c00c827e97d1ba31
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout afba2bc036b0ed983bef6bd7c00c827e97d1ba31
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/btrfs/zoned.c:1697: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Activate block group and underlying device zones


vim +1697 fs/btrfs/zoned.c

  1695	
  1696	/**
> 1697	 * Activate block group and underlying device zones
  1698	 *
  1699	 * @block_group: the block group to activate
  1700	 *
  1701	 * Return: true on success, false otherwise
  1702	 */
  1703	bool btrfs_zone_activate(struct btrfs_block_group *block_group)
  1704	{
  1705		struct btrfs_fs_info *fs_info = block_group->fs_info;
  1706		struct map_lookup *map;
  1707		struct btrfs_device *device;
  1708		u64 physical;
  1709		bool ret;
  1710	
  1711		if (!btrfs_is_zoned(block_group->fs_info))
  1712			return true;
  1713	
  1714		map = block_group->physical_map;
  1715		/* Currently support SINGLE profile only */
  1716		ASSERT(map->num_stripes == 1);
  1717		device = map->stripes[0].dev;
  1718		physical = map->stripes[0].physical;
  1719	
  1720		if (device->zone_info->max_active_zones == 0)
  1721			return true;
  1722	
  1723		spin_lock(&block_group->lock);
  1724	
  1725		if (block_group->zone_is_active) {
  1726			ret = true;
  1727			goto out_unlock;
  1728		}
  1729	
  1730		/* No space left */
  1731		if (block_group->alloc_offset == block_group->zone_capacity) {
  1732			ret = false;
  1733			goto out_unlock;
  1734		}
  1735	
  1736		if (!btrfs_dev_set_active_zone(device, physical)) {
  1737			/* Cannot activate the zone */
  1738			ret = false;
  1739			goto out_unlock;
  1740		}
  1741	
  1742		/* Successfully activated all the zones */
  1743		block_group->zone_is_active = 1;
  1744	
  1745		spin_unlock(&block_group->lock);
  1746	
  1747		/* For the active block group list */
  1748		btrfs_get_block_group(block_group);
  1749	
  1750		spin_lock(&fs_info->zone_active_bgs_lock);
  1751		ASSERT(list_empty(&block_group->active_bg_list));
  1752		list_add_tail(&block_group->active_bg_list, &fs_info->zone_active_bgs);
  1753		spin_unlock(&fs_info->zone_active_bgs_lock);
  1754	
  1755		return true;
  1756	
  1757	out_unlock:
  1758		spin_unlock(&block_group->lock);
  1759		return ret;
  1760	}
  1761	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36121 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: fs/btrfs/zoned.c:1697: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Date: Thu, 18 Nov 2021 09:00:09 +0800	[thread overview]
Message-ID: <202111180903.CVuFf9Tz-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3546 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: afba2bc036b0ed983bef6bd7c00c827e97d1ba31 btrfs: zoned: implement active zone tracking
date:   3 weeks ago
config: m68k-randconfig-r004-20211109 (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=afba2bc036b0ed983bef6bd7c00c827e97d1ba31
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout afba2bc036b0ed983bef6bd7c00c827e97d1ba31
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/btrfs/zoned.c:1697: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Activate block group and underlying device zones


vim +1697 fs/btrfs/zoned.c

  1695	
  1696	/**
> 1697	 * Activate block group and underlying device zones
  1698	 *
  1699	 * @block_group: the block group to activate
  1700	 *
  1701	 * Return: true on success, false otherwise
  1702	 */
  1703	bool btrfs_zone_activate(struct btrfs_block_group *block_group)
  1704	{
  1705		struct btrfs_fs_info *fs_info = block_group->fs_info;
  1706		struct map_lookup *map;
  1707		struct btrfs_device *device;
  1708		u64 physical;
  1709		bool ret;
  1710	
  1711		if (!btrfs_is_zoned(block_group->fs_info))
  1712			return true;
  1713	
  1714		map = block_group->physical_map;
  1715		/* Currently support SINGLE profile only */
  1716		ASSERT(map->num_stripes == 1);
  1717		device = map->stripes[0].dev;
  1718		physical = map->stripes[0].physical;
  1719	
  1720		if (device->zone_info->max_active_zones == 0)
  1721			return true;
  1722	
  1723		spin_lock(&block_group->lock);
  1724	
  1725		if (block_group->zone_is_active) {
  1726			ret = true;
  1727			goto out_unlock;
  1728		}
  1729	
  1730		/* No space left */
  1731		if (block_group->alloc_offset == block_group->zone_capacity) {
  1732			ret = false;
  1733			goto out_unlock;
  1734		}
  1735	
  1736		if (!btrfs_dev_set_active_zone(device, physical)) {
  1737			/* Cannot activate the zone */
  1738			ret = false;
  1739			goto out_unlock;
  1740		}
  1741	
  1742		/* Successfully activated all the zones */
  1743		block_group->zone_is_active = 1;
  1744	
  1745		spin_unlock(&block_group->lock);
  1746	
  1747		/* For the active block group list */
  1748		btrfs_get_block_group(block_group);
  1749	
  1750		spin_lock(&fs_info->zone_active_bgs_lock);
  1751		ASSERT(list_empty(&block_group->active_bg_list));
  1752		list_add_tail(&block_group->active_bg_list, &fs_info->zone_active_bgs);
  1753		spin_unlock(&fs_info->zone_active_bgs_lock);
  1754	
  1755		return true;
  1756	
  1757	out_unlock:
  1758		spin_unlock(&block_group->lock);
  1759		return ret;
  1760	}
  1761	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36121 bytes --]

             reply	other threads:[~2021-11-18  1:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18  1:00 kernel test robot [this message]
2021-11-18  1:00 ` fs/btrfs/zoned.c:1697: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111180903.CVuFf9Tz-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dsterba@suse.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.