From: kernel test robot <lkp@intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>,
nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, michael.a.bottini@linux.intel.com,
rafael@kernel.org
Cc: kbuild-all@lists.01.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices
Date: Sat, 20 Nov 2021 13:13:14 +0800 [thread overview]
Message-ID: <202111201322.akr2JWLt-lkp@intel.com> (raw)
In-Reply-To: <20211120015756.1396263-2-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2370 bytes --]
Hi "David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on v5.16-rc1 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211120-095959
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-a012-20211118 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d0452407e2d5bf22bd1094654d7e868311b7c94e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211120-095959
git checkout d0452407e2d5bf22bd1094654d7e868311b7c94e
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pci/controller/vmd.c:676:5: warning: no previous prototype for 'vmd_enable_aspm' [-Wmissing-prototypes]
676 | int vmd_enable_aspm(struct pci_dev *pdev, void *userdata)
| ^~~~~~~~~~~~~~~
vim +/vmd_enable_aspm +676 drivers/pci/controller/vmd.c
671
672 /*
673 * Override the BIOS ASPM policy and set the LTR value for PCI storage
674 * devices on the VMD bride.
675 */
> 676 int vmd_enable_aspm(struct pci_dev *pdev, void *userdata)
677 {
678 int features = *(int *)userdata;
679
680 if (features & VMD_FEAT_QUIRK_OVERRIDE_ASPM &&
681 pdev->class == PCI_CLASS_STORAGE_EXPRESS) {
682 int pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_LTR);
683
684 if (pos) {
685 pci_write_config_word(pdev, pos + PCI_LTR_MAX_SNOOP_LAT, 0x1003);
686 pci_write_config_word(pdev, pos + PCI_LTR_MAX_NOSNOOP_LAT, 0x1003);
687 pcie_aspm_policy_override(pdev);
688 }
689 }
690 return 0;
691 }
692
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41220 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices
Date: Sat, 20 Nov 2021 13:13:14 +0800 [thread overview]
Message-ID: <202111201322.akr2JWLt-lkp@intel.com> (raw)
In-Reply-To: <20211120015756.1396263-2-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2432 bytes --]
Hi "David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on v5.16-rc1 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211120-095959
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-a012-20211118 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d0452407e2d5bf22bd1094654d7e868311b7c94e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211120-095959
git checkout d0452407e2d5bf22bd1094654d7e868311b7c94e
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pci/controller/vmd.c:676:5: warning: no previous prototype for 'vmd_enable_aspm' [-Wmissing-prototypes]
676 | int vmd_enable_aspm(struct pci_dev *pdev, void *userdata)
| ^~~~~~~~~~~~~~~
vim +/vmd_enable_aspm +676 drivers/pci/controller/vmd.c
671
672 /*
673 * Override the BIOS ASPM policy and set the LTR value for PCI storage
674 * devices on the VMD bride.
675 */
> 676 int vmd_enable_aspm(struct pci_dev *pdev, void *userdata)
677 {
678 int features = *(int *)userdata;
679
680 if (features & VMD_FEAT_QUIRK_OVERRIDE_ASPM &&
681 pdev->class == PCI_CLASS_STORAGE_EXPRESS) {
682 int pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_LTR);
683
684 if (pos) {
685 pci_write_config_word(pdev, pos + PCI_LTR_MAX_SNOOP_LAT, 0x1003);
686 pci_write_config_word(pdev, pos + PCI_LTR_MAX_NOSNOOP_LAT, 0x1003);
687 pcie_aspm_policy_override(pdev);
688 }
689 }
690 return 0;
691 }
692
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41220 bytes --]
next prev parent reply other threads:[~2021-11-20 5:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 1:57 [PATCH 1/2] PCI/ASPM: Add ASPM BIOS override function David E. Box
2021-11-20 1:57 ` [PATCH 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices David E. Box
2021-11-20 5:13 ` kernel test robot [this message]
2021-11-20 5:13 ` kernel test robot
2021-11-20 16:35 ` kernel test robot
2021-11-20 16:35 ` kernel test robot
2021-11-30 8:03 ` [PATCH 1/2] PCI/ASPM: Add ASPM BIOS override function Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111201322.akr2JWLt-lkp@intel.com \
--to=lkp@intel.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=jonathan.derrick@linux.dev \
--cc=kbuild-all@lists.01.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michael.a.bottini@linux.intel.com \
--cc=nirmal.patel@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.