All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Markus Niebel <Markus.Niebel@ew.tq-group.com>
Subject: Re: [PATCH v2 2/3] ARM: dts: imx6qdl: tqma6: add ERR006687 hardware workaround for "a" variant
Date: Mon, 22 Nov 2021 08:46:38 +0800	[thread overview]
Message-ID: <20211122004637.GQ31998@dragon> (raw)
In-Reply-To: <20211103115618.13927-2-matthias.schiffer@ew.tq-group.com>

On Wed, Nov 03, 2021 at 12:56:17PM +0100, Matthias Schiffer wrote:
> The TQMa6x "a" has a workaround for ERR006687 implemented in hardware.
> Add the required pinmuxing and related setup to make use of this.
> 
> As board DTS files based on the TQMa6x SoMs will define their own
> pinmuxing for the FEC ethernet controller as well, we can't apply this
> pin group unconditionally; instead, it is the responsibility of the
> board DTs derived from imx6qdl-tqma6a.dtsi to include this group.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

"ARM: dts: imx6qdl-tqma6: ..." for subject prefix.

Shawn

> ---
> 
> v2: no changes
> 
>  arch/arm/boot/dts/imx6qdl-tqma6a.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi b/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> index b679bec78e6c..bfb67da64b96 100644
> --- a/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> @@ -4,6 +4,12 @@
>   * Copyright 2013-2017 Markus Niebel <Markus.Niebel@tq-group.com>
>   */
>  
> +&fec {
> +	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
> +			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> +	fsl,err006687-workaround-present;
> +};
> +
>  &i2c1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_i2c1>;
> @@ -26,3 +32,17 @@
>  		pagesize = <32>;
>  	};
>  };
> +
> +&iomuxc {
> +	/*
> +	 * This pinmuxing is required for the ERR006687 workaround. Board
> +	 * DTS files that enable the FEC controller with
> +	 * fsl,err006687-workaround-present must include this group.
> +	 */
> +	pinctrl_enet_fix: enetfixgrp {
> +		fsl,pins = <
> +			/* ENET ping patch */
> +			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
> +		>;
> +	};
> +};
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Markus Niebel <Markus.Niebel@ew.tq-group.com>
Subject: Re: [PATCH v2 2/3] ARM: dts: imx6qdl: tqma6: add ERR006687 hardware workaround for "a" variant
Date: Mon, 22 Nov 2021 08:46:38 +0800	[thread overview]
Message-ID: <20211122004637.GQ31998@dragon> (raw)
In-Reply-To: <20211103115618.13927-2-matthias.schiffer@ew.tq-group.com>

On Wed, Nov 03, 2021 at 12:56:17PM +0100, Matthias Schiffer wrote:
> The TQMa6x "a" has a workaround for ERR006687 implemented in hardware.
> Add the required pinmuxing and related setup to make use of this.
> 
> As board DTS files based on the TQMa6x SoMs will define their own
> pinmuxing for the FEC ethernet controller as well, we can't apply this
> pin group unconditionally; instead, it is the responsibility of the
> board DTs derived from imx6qdl-tqma6a.dtsi to include this group.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

"ARM: dts: imx6qdl-tqma6: ..." for subject prefix.

Shawn

> ---
> 
> v2: no changes
> 
>  arch/arm/boot/dts/imx6qdl-tqma6a.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi b/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> index b679bec78e6c..bfb67da64b96 100644
> --- a/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> @@ -4,6 +4,12 @@
>   * Copyright 2013-2017 Markus Niebel <Markus.Niebel@tq-group.com>
>   */
>  
> +&fec {
> +	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
> +			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> +	fsl,err006687-workaround-present;
> +};
> +
>  &i2c1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_i2c1>;
> @@ -26,3 +32,17 @@
>  		pagesize = <32>;
>  	};
>  };
> +
> +&iomuxc {
> +	/*
> +	 * This pinmuxing is required for the ERR006687 workaround. Board
> +	 * DTS files that enable the FEC controller with
> +	 * fsl,err006687-workaround-present must include this group.
> +	 */
> +	pinctrl_enet_fix: enetfixgrp {
> +		fsl,pins = <
> +			/* ENET ping patch */
> +			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
> +		>;
> +	};
> +};
> -- 
> 2.17.1
> 

  reply	other threads:[~2021-11-22  0:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 11:56 [PATCH v2 1/3] dt-bindings: arm: fsl: add TQ-Systems boards based on i.MX6Q/QP/DL Matthias Schiffer
2021-11-03 11:56 ` Matthias Schiffer
2021-11-03 11:56 ` [PATCH v2 2/3] ARM: dts: imx6qdl: tqma6: add ERR006687 hardware workaround for "a" variant Matthias Schiffer
2021-11-03 11:56   ` Matthias Schiffer
2021-11-22  0:46   ` Shawn Guo [this message]
2021-11-22  0:46     ` Shawn Guo
2021-11-03 11:56 ` [PATCH v2 3/3] ARM: dts: imx6qdl: add TQ-Systems MBa6x device trees Matthias Schiffer
2021-11-03 11:56   ` Matthias Schiffer
2021-11-22  0:45   ` Shawn Guo
2021-11-22  0:45     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122004637.GQ31998@dragon \
    --to=shawnguo@kernel.org \
    --cc=Markus.Niebel@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.