All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Peng Fan <peng.fan@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/1] arm64: dts: imx8qm: Add fsl,imx7ulp-lpuart compatible to lpuart
Date: Mon, 22 Nov 2021 09:43:15 +0800	[thread overview]
Message-ID: <20211122014314.GV31998@dragon> (raw)
In-Reply-To: <20211116125814.2674343-1-alexander.stein@ew.tq-group.com>

On Tue, Nov 16, 2021 at 01:58:14PM +0100, Alexander Stein wrote:
> After commit b4b844930f27 ("tty: serial: fsl_lpuart: drop earlycon entry
> for i.MX8QXP") earlycon support was essentially removed from
> imx8qm/imx8qxp due to missing compatible.
> The commit message says "i.MX8QXP lpuart is compatible with i.MX7ULP" so
> adding a fallback compatible should be fine.
> With this change earlycon is supported again on imx8qm/imx8qxp.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> Changes in v2:
> * Fix typo in commit message: 'early' -> 'earlycon'
> 
>  arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> index bbe5f5ecfb92..3486b99ab6eb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> @@ -19,19 +19,19 @@ uart4_lpcg: clock-controller@5a4a0000 {
>  };
>  
>  &lpuart0 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";

Then fsl,imx8qxp-lpuart should be dropped?

Shawn

>  };
>  
>  &lpuart1 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
>  };
>  
>  &lpuart2 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
>  };
>  
>  &lpuart3 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
>  };
>  
>  &i2c0 {
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Peng Fan <peng.fan@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/1] arm64: dts: imx8qm: Add fsl,imx7ulp-lpuart compatible to lpuart
Date: Mon, 22 Nov 2021 09:43:15 +0800	[thread overview]
Message-ID: <20211122014314.GV31998@dragon> (raw)
In-Reply-To: <20211116125814.2674343-1-alexander.stein@ew.tq-group.com>

On Tue, Nov 16, 2021 at 01:58:14PM +0100, Alexander Stein wrote:
> After commit b4b844930f27 ("tty: serial: fsl_lpuart: drop earlycon entry
> for i.MX8QXP") earlycon support was essentially removed from
> imx8qm/imx8qxp due to missing compatible.
> The commit message says "i.MX8QXP lpuart is compatible with i.MX7ULP" so
> adding a fallback compatible should be fine.
> With this change earlycon is supported again on imx8qm/imx8qxp.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> Changes in v2:
> * Fix typo in commit message: 'early' -> 'earlycon'
> 
>  arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> index bbe5f5ecfb92..3486b99ab6eb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> @@ -19,19 +19,19 @@ uart4_lpcg: clock-controller@5a4a0000 {
>  };
>  
>  &lpuart0 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";

Then fsl,imx8qxp-lpuart should be dropped?

Shawn

>  };
>  
>  &lpuart1 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
>  };
>  
>  &lpuart2 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
>  };
>  
>  &lpuart3 {
> -	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> +	compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
>  };
>  
>  &i2c0 {
> -- 
> 2.25.1
> 

  reply	other threads:[~2021-11-22  1:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 12:58 [PATCH v2 1/1] arm64: dts: imx8qm: Add fsl, imx7ulp-lpuart compatible to lpuart Alexander Stein
2021-11-16 12:58 ` [PATCH v2 1/1] arm64: dts: imx8qm: Add fsl,imx7ulp-lpuart " Alexander Stein
2021-11-22  1:43 ` Shawn Guo [this message]
2021-11-22  1:43   ` Shawn Guo
2021-11-22  7:38   ` (EXT) Re: [PATCH v2 1/1] arm64: dts: imx8qm: Add fsl, imx7ulp-lpuart " Alexander Stein
2021-11-22  7:38     ` Alexander Stein
2021-11-23 12:15     ` Shawn Guo
2021-11-23 12:15       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122014314.GV31998@dragon \
    --to=shawnguo@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.