All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Mathew McBride <matt@traverse.com.au>
Cc: Li Yang <leoyang.li@nxp.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys
Date: Tue, 23 Nov 2021 20:26:05 +0800	[thread overview]
Message-ID: <20211123122605.GE4216@dragon> (raw)
In-Reply-To: <20211122025554.15338-1-matt@traverse.com.au>

On Mon, Nov 22, 2021 at 02:55:54AM +0000, Mathew McBride wrote:
> gpio-keys already 'inherits' the interrupts from the controller
> of the specified GPIO, so having another declaration is redundant.
> On >=v5.15 this started causing an oops under gpio_keys_probe as
> the IRQ was already claimed.
> 
> Signed-off-by: Mathew McBride <matt@traverse.com.au>
> Fixes: 418962eea358 ("arm64: dts: add device tree for Traverse Ten64 (LS1088A)")
> Cc: stable@vger.kernel.org

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Mathew McBride <matt@traverse.com.au>
Cc: Li Yang <leoyang.li@nxp.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys
Date: Tue, 23 Nov 2021 20:26:05 +0800	[thread overview]
Message-ID: <20211123122605.GE4216@dragon> (raw)
In-Reply-To: <20211122025554.15338-1-matt@traverse.com.au>

On Mon, Nov 22, 2021 at 02:55:54AM +0000, Mathew McBride wrote:
> gpio-keys already 'inherits' the interrupts from the controller
> of the specified GPIO, so having another declaration is redundant.
> On >=v5.15 this started causing an oops under gpio_keys_probe as
> the IRQ was already claimed.
> 
> Signed-off-by: Mathew McBride <matt@traverse.com.au>
> Fixes: 418962eea358 ("arm64: dts: add device tree for Traverse Ten64 (LS1088A)")
> Cc: stable@vger.kernel.org

Applied, thanks!

  reply	other threads:[~2021-11-23 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22  2:55 [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys Mathew McBride
2021-11-22  2:55 ` Mathew McBride
2021-11-23 12:26 ` Shawn Guo [this message]
2021-11-23 12:26   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211123122605.GE4216@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=matt@traverse.com.au \
    --cc=robh+dt@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.