All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: kbuild-all@lists.01.org, linux-hwmon@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: [groeck-staging:watchdog-next 11/23] drivers/watchdog/s3c2410_wdt.c:94: warning: expecting prototype for Quirk flags for different Samsung watchdog IP(). Prototype was for QUIRK_HAS_WTCLRINT_REG() instead
Date: Tue, 23 Nov 2021 20:27:07 +0800	[thread overview]
Message-ID: <202111232037.iwzPIkeS-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
head:   5c9a4cc5516e30ac2e0586e315e0806ae766321b
commit: 10748806ee44ad974d7ccd84c682222213b53e69 [11/23] watchdog: s3c2410: Cleanup PMU related code
config: arc-randconfig-r015-20211117 (https://download.01.org/0day-ci/archive/20211123/202111232037.iwzPIkeS-lkp@intel.com/config.gz)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=10748806ee44ad974d7ccd84c682222213b53e69
        git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
        git fetch --no-tags groeck-staging watchdog-next
        git checkout 10748806ee44ad974d7ccd84c682222213b53e69
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/watchdog/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/watchdog/s3c2410_wdt.c:94: warning: expecting prototype for Quirk flags for different Samsung watchdog IP(). Prototype was for QUIRK_HAS_WTCLRINT_REG() instead


vim +94 drivers/watchdog/s3c2410_wdt.c

    59	
    60	/**
    61	 * Quirk flags for different Samsung watchdog IP-cores.
    62	 *
    63	 * This driver supports multiple Samsung SoCs, each of which might have
    64	 * different set of registers and features supported. As watchdog block
    65	 * sometimes requires modifying PMU registers for proper functioning, register
    66	 * differences in both watchdog and PMU IP-cores should be accounted for. Quirk
    67	 * flags described below serve the purpose of telling the driver about mentioned
    68	 * SoC traits, and can be specified in driver data for each particular supported
    69	 * device.
    70	 *
    71	 * %QUIRK_HAS_WTCLRINT_REG: Watchdog block has WTCLRINT register. It's used to
    72	 * clear the interrupt once the interrupt service routine is complete. It's
    73	 * write-only, writing any values to this register clears the interrupt, but
    74	 * reading is not permitted.
    75	 *
    76	 * %QUIRK_HAS_PMU_MASK_RESET: PMU block has the register for disabling/enabling
    77	 * WDT reset request. On old SoCs it's usually called MASK_WDT_RESET_REQUEST,
    78	 * new SoCs have CLUSTERx_NONCPU_INT_EN register, which 'mask_bit' value is
    79	 * inverted compared to the former one.
    80	 *
    81	 * %QUIRK_HAS_PMU_RST_STAT: PMU block has RST_STAT (reset status) register,
    82	 * which contains bits indicating the reason for most recent CPU reset. If
    83	 * present, driver will use this register to check if previous reboot was due to
    84	 * watchdog timer reset.
    85	 *
    86	 * %QUIRK_HAS_PMU_AUTO_DISABLE: PMU block has AUTOMATIC_WDT_RESET_DISABLE
    87	 * register. If 'mask_bit' bit is set, PMU will disable WDT reset when
    88	 * corresponding processor is in reset state.
    89	 *
    90	 * %QUIRK_HAS_PMU_CNT_EN: PMU block has some register (e.g. CLUSTERx_NONCPU_OUT)
    91	 * with "watchdog counter enable" bit. That bit should be set to make watchdog
    92	 * counter running.
    93	 */
  > 94	#define QUIRK_HAS_WTCLRINT_REG			(1 << 0)
    95	#define QUIRK_HAS_PMU_MASK_RESET		(1 << 1)
    96	#define QUIRK_HAS_PMU_RST_STAT			(1 << 2)
    97	#define QUIRK_HAS_PMU_AUTO_DISABLE		(1 << 3)
    98	#define QUIRK_HAS_PMU_CNT_EN			(1 << 4)
    99	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [groeck-staging:watchdog-next 11/23] drivers/watchdog/s3c2410_wdt.c:94: warning: expecting prototype for Quirk flags for different Samsung watchdog IP(). Prototype was for QUIRK_HAS_WTCLRINT_REG() instead
Date: Tue, 23 Nov 2021 20:27:07 +0800	[thread overview]
Message-ID: <202111232037.iwzPIkeS-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3926 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
head:   5c9a4cc5516e30ac2e0586e315e0806ae766321b
commit: 10748806ee44ad974d7ccd84c682222213b53e69 [11/23] watchdog: s3c2410: Cleanup PMU related code
config: arc-randconfig-r015-20211117 (https://download.01.org/0day-ci/archive/20211123/202111232037.iwzPIkeS-lkp(a)intel.com/config.gz)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=10748806ee44ad974d7ccd84c682222213b53e69
        git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
        git fetch --no-tags groeck-staging watchdog-next
        git checkout 10748806ee44ad974d7ccd84c682222213b53e69
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/watchdog/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/watchdog/s3c2410_wdt.c:94: warning: expecting prototype for Quirk flags for different Samsung watchdog IP(). Prototype was for QUIRK_HAS_WTCLRINT_REG() instead


vim +94 drivers/watchdog/s3c2410_wdt.c

    59	
    60	/**
    61	 * Quirk flags for different Samsung watchdog IP-cores.
    62	 *
    63	 * This driver supports multiple Samsung SoCs, each of which might have
    64	 * different set of registers and features supported. As watchdog block
    65	 * sometimes requires modifying PMU registers for proper functioning, register
    66	 * differences in both watchdog and PMU IP-cores should be accounted for. Quirk
    67	 * flags described below serve the purpose of telling the driver about mentioned
    68	 * SoC traits, and can be specified in driver data for each particular supported
    69	 * device.
    70	 *
    71	 * %QUIRK_HAS_WTCLRINT_REG: Watchdog block has WTCLRINT register. It's used to
    72	 * clear the interrupt once the interrupt service routine is complete. It's
    73	 * write-only, writing any values to this register clears the interrupt, but
    74	 * reading is not permitted.
    75	 *
    76	 * %QUIRK_HAS_PMU_MASK_RESET: PMU block has the register for disabling/enabling
    77	 * WDT reset request. On old SoCs it's usually called MASK_WDT_RESET_REQUEST,
    78	 * new SoCs have CLUSTERx_NONCPU_INT_EN register, which 'mask_bit' value is
    79	 * inverted compared to the former one.
    80	 *
    81	 * %QUIRK_HAS_PMU_RST_STAT: PMU block has RST_STAT (reset status) register,
    82	 * which contains bits indicating the reason for most recent CPU reset. If
    83	 * present, driver will use this register to check if previous reboot was due to
    84	 * watchdog timer reset.
    85	 *
    86	 * %QUIRK_HAS_PMU_AUTO_DISABLE: PMU block has AUTOMATIC_WDT_RESET_DISABLE
    87	 * register. If 'mask_bit' bit is set, PMU will disable WDT reset when
    88	 * corresponding processor is in reset state.
    89	 *
    90	 * %QUIRK_HAS_PMU_CNT_EN: PMU block has some register (e.g. CLUSTERx_NONCPU_OUT)
    91	 * with "watchdog counter enable" bit. That bit should be set to make watchdog
    92	 * counter running.
    93	 */
  > 94	#define QUIRK_HAS_WTCLRINT_REG			(1 << 0)
    95	#define QUIRK_HAS_PMU_MASK_RESET		(1 << 1)
    96	#define QUIRK_HAS_PMU_RST_STAT			(1 << 2)
    97	#define QUIRK_HAS_PMU_AUTO_DISABLE		(1 << 3)
    98	#define QUIRK_HAS_PMU_CNT_EN			(1 << 4)
    99	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

             reply	other threads:[~2021-11-23 12:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 12:27 kernel test robot [this message]
2021-11-23 12:27 ` [groeck-staging:watchdog-next 11/23] drivers/watchdog/s3c2410_wdt.c:94: warning: expecting prototype for Quirk flags for different Samsung watchdog IP(). Prototype was for QUIRK_HAS_WTCLRINT_REG() instead kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111232037.iwzPIkeS-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=semen.protsenko@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.