* [PATCH for-next] RDMA/siw: Use helper function to set sys_image_guid
@ 2021-11-24 10:23 Kamal Heib
2021-11-24 11:03 ` Bernard Metzler
2021-11-25 17:37 ` [PATCH " Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Kamal Heib @ 2021-11-24 10:23 UTC (permalink / raw)
To: linux-rdma; +Cc: Bernard Metzler, Jason Gunthorpe, Kamal Heib
Use the addrconf_addr_eui48() helper function to set the sys_image_guid,
Also make sure the GUID is valid EUI-64 identifier.
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/sw/siw/siw_verbs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c
index 1b36350601fa..d15a1f9c59f0 100644
--- a/drivers/infiniband/sw/siw/siw_verbs.c
+++ b/drivers/infiniband/sw/siw/siw_verbs.c
@@ -8,6 +8,7 @@
#include <linux/uaccess.h>
#include <linux/vmalloc.h>
#include <linux/xarray.h>
+#include <net/addrconf.h>
#include <rdma/iw_cm.h>
#include <rdma/ib_verbs.h>
@@ -155,7 +156,8 @@ int siw_query_device(struct ib_device *base_dev, struct ib_device_attr *attr,
attr->vendor_id = SIW_VENDOR_ID;
attr->vendor_part_id = sdev->vendor_part_id;
- memcpy(&attr->sys_image_guid, sdev->netdev->dev_addr, 6);
+ addrconf_addr_eui48((u8 *)&attr->sys_image_guid,
+ sdev->netdev->dev_addr);
return 0;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re:[PATCH for-next] RDMA/siw: Use helper function to set sys_image_guid
2021-11-24 10:23 [PATCH for-next] RDMA/siw: Use helper function to set sys_image_guid Kamal Heib
@ 2021-11-24 11:03 ` Bernard Metzler
2021-11-25 17:37 ` [PATCH " Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Bernard Metzler @ 2021-11-24 11:03 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Jason Gunthorpe
-----"Kamal Heib" <kamalheib1@gmail.com> wrote: -----
>To: linux-rdma@vger.kernel.org
>From: "Kamal Heib" <kamalheib1@gmail.com>
>Date: 11/24/2021 11:24AM
>Cc: "Bernard Metzler" <bmt@zurich.ibm.com>, "Jason Gunthorpe"
><jgg@ziepe.ca>, "Kamal Heib" <kamalheib1@gmail.com>
>Subject: [EXTERNAL] [PATCH for-next] RDMA/siw: Use helper function to
>set sys_image_guid
>
>Use the addrconf_addr_eui48() helper function to set the
>sys_image_guid,
>Also make sure the GUID is valid EUI-64 identifier.
>
>Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index 1b36350601fa..d15a1f9c59f0 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -8,6 +8,7 @@
> #include <linux/uaccess.h>
> #include <linux/vmalloc.h>
> #include <linux/xarray.h>
>+#include <net/addrconf.h>
>
> #include <rdma/iw_cm.h>
> #include <rdma/ib_verbs.h>
>@@ -155,7 +156,8 @@ int siw_query_device(struct ib_device *base_dev,
>struct ib_device_attr *attr,
> attr->vendor_id = SIW_VENDOR_ID;
> attr->vendor_part_id = sdev->vendor_part_id;
>
>- memcpy(&attr->sys_image_guid, sdev->netdev->dev_addr, 6);
>+ addrconf_addr_eui48((u8 *)&attr->sys_image_guid,
>+ sdev->netdev->dev_addr);
>
> return 0;
> }
>--
>2.31.1
>
>
Thanks, Kamal!
Acked-by: Bernard Metzler <bmt@zurich.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-next] RDMA/siw: Use helper function to set sys_image_guid
2021-11-24 10:23 [PATCH for-next] RDMA/siw: Use helper function to set sys_image_guid Kamal Heib
2021-11-24 11:03 ` Bernard Metzler
@ 2021-11-25 17:37 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-11-25 17:37 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Bernard Metzler
On Wed, Nov 24, 2021 at 12:23:36PM +0200, Kamal Heib wrote:
> Use the addrconf_addr_eui48() helper function to set the sys_image_guid,
> Also make sure the GUID is valid EUI-64 identifier.
>
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> Acked-by: Bernard Metzler <bmt@zurich.ibm.com>
> ---
> drivers/infiniband/sw/siw/siw_verbs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-25 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-24 10:23 [PATCH for-next] RDMA/siw: Use helper function to set sys_image_guid Kamal Heib
2021-11-24 11:03 ` Bernard Metzler
2021-11-25 17:37 ` [PATCH " Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.