Re: [RFC PATCH bpf-next 3/8] xsk: handle XDP_REDIRECT_XSK and expose xsk_rcv/flush

[kernel test robot <lkp@intel.com>]

Hi Ciara,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Ciara-Loftus/XDP_REDIRECT_XSK-and-Batched-AF_XDP-Rx/20211116-153952
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-a004-20211116 (https://download.01.org/0day-ci/archive/20211127/202111271955.w9AzLVNN-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project fbe72e41b99dc7994daac300d208a955be3e4a0a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/06daa8f48870f74b06ed02fe7f36b820c09844c9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ciara-Loftus/XDP_REDIRECT_XSK-and-Batched-AF_XDP-Rx/20211116-153952
        git checkout 06daa8f48870f74b06ed02fe7f36b820c09844c9
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> net/core/dev.c:4883:5: error: expected expression
                                   struct xdp_sock *xs =
                                   ^
>> net/core/dev.c:4886:27: error: use of undeclared identifier 'xs'
                                   err = xsk_generic_rcv(xs, &xdp);
                                                         ^
   2 errors generated.


vim +4883 net/core/dev.c

  4870	
  4871	int do_xdp_generic(struct bpf_prog *xdp_prog, struct sk_buff *skb)
  4872	{
  4873		if (xdp_prog) {
  4874			struct xdp_buff xdp;
  4875			u32 act;
  4876			int err;
  4877	
  4878			act = netif_receive_generic_xdp(skb, &xdp, xdp_prog);
  4879			if (act != XDP_PASS) {
  4880				switch (act) {
  4881	#ifdef CONFIG_XDP_SOCKETS
  4882				case XDP_REDIRECT_XSK:
> 4883					struct xdp_sock *xs =
  4884						READ_ONCE(skb->dev->_rx[xdp.rxq->queue_index].xsk);
  4885	
> 4886					err = xsk_generic_rcv(xs, &xdp);
  4887					if (err)
  4888						goto out_redir;
  4889					consume_skb(skb);
  4890					break;
  4891	#endif
  4892				case XDP_REDIRECT:
  4893					err = xdp_do_generic_redirect(skb->dev, skb,
  4894								      &xdp, xdp_prog);
  4895					if (err)
  4896						goto out_redir;
  4897					break;
  4898				case XDP_TX:
  4899					generic_xdp_tx(skb, xdp_prog);
  4900					break;
  4901				}
  4902				return XDP_DROP;
  4903			}
  4904		}
  4905		return XDP_PASS;
  4906	out_redir:
  4907		kfree_skb(skb);
  4908		return XDP_DROP;
  4909	}
  4910	EXPORT_SYMBOL_GPL(do_xdp_generic);
  4911	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org