Re: [PATCH V4 5/9] soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl

[kernel test robot <lkp@intel.com>]

Hi Adam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on shawnguo/for-next soc/for-next rockchip/for-next v5.16-rc2 next-20211126]
[cannot apply to arm/for-next xilinx-xlnx/master arm64/for-next/core clk/clk-next kvmarm/next keystone/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Adam-Ford/arm64-imx8mn-Enable-more-imx8m-Nano-functions/20211128-212356
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: nios2-randconfig-s031-20211128 (https://download.01.org/0day-ci/archive/20211129/202111290057.IessF4BL-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/4e41d7dd6745650d1f0e0015c876aeff76709054
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Adam-Ford/arm64-imx8mn-Enable-more-imx8m-Nano-functions/20211128-212356
        git checkout 4e41d7dd6745650d1f0e0015c876aeff76709054
        # save the config file to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/soc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/soc/imx/imx8m-blk-ctrl.c:536:18: error: 'const struct imx8m_blk_ctrl_domain_data' has no member named 'mipi_phy_rst_mask'
     536 |                 .mipi_phy_rst_mask = BIT(17),
         |                  ^~~~~~~~~~~~~~~~~
   In file included from include/linux/bits.h:6,
                    from include/linux/ratelimit_types.h:5,
                    from include/linux/ratelimit.h:5,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from drivers/soc/imx/imx8m-blk-ctrl.c:7:
   include/vdso/bits.h:7:33: warning: excess elements in struct initializer
       7 | #define BIT(nr)                 (UL(1) << (nr))
         |                                 ^
   drivers/soc/imx/imx8m-blk-ctrl.c:536:38: note: in expansion of macro 'BIT'
     536 |                 .mipi_phy_rst_mask = BIT(17),
         |                                      ^~~
   include/vdso/bits.h:7:33: note: (near initialization for 'imx8mn_disp_blk_ctl_domain_data[0]')
       7 | #define BIT(nr)                 (UL(1) << (nr))
         |                                 ^
   drivers/soc/imx/imx8m-blk-ctrl.c:536:38: note: in expansion of macro 'BIT'
     536 |                 .mipi_phy_rst_mask = BIT(17),
         |                                      ^~~
   drivers/soc/imx/imx8m-blk-ctrl.c:545:18: error: 'const struct imx8m_blk_ctrl_domain_data' has no member named 'mipi_phy_rst_mask'
     545 |                 .mipi_phy_rst_mask = BIT(16),
         |                  ^~~~~~~~~~~~~~~~~
   In file included from include/linux/bits.h:6,
                    from include/linux/ratelimit_types.h:5,
                    from include/linux/ratelimit.h:5,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from drivers/soc/imx/imx8m-blk-ctrl.c:7:
   include/vdso/bits.h:7:33: warning: excess elements in struct initializer
       7 | #define BIT(nr)                 (UL(1) << (nr))
         |                                 ^
   drivers/soc/imx/imx8m-blk-ctrl.c:545:38: note: in expansion of macro 'BIT'
     545 |                 .mipi_phy_rst_mask = BIT(16),
         |                                      ^~~
   include/vdso/bits.h:7:33: note: (near initialization for 'imx8mn_disp_blk_ctl_domain_data[1]')
       7 | #define BIT(nr)                 (UL(1) << (nr))
         |                                 ^
   drivers/soc/imx/imx8m-blk-ctrl.c:545:38: note: in expansion of macro 'BIT'
     545 |                 .mipi_phy_rst_mask = BIT(16),
         |                                      ^~~


vim +536 drivers/soc/imx/imx8m-blk-ctrl.c

   527	
   528	static const struct imx8m_blk_ctrl_domain_data imx8mn_disp_blk_ctl_domain_data[] = {
   529		[IMX8MN_DISPBLK_PD_MIPI_DSI] = {
   530			.name = "dispblk-mipi-dsi",
   531			.clk_names = (const char *[]){ "dsi-pclk", "dsi-ref", },
   532			.num_clks = 2,
   533			.gpc_name = "mipi-dsi",
   534			.rst_mask = BIT(0) | BIT(1),
   535			.clk_mask = BIT(0) | BIT(1),
 > 536			.mipi_phy_rst_mask = BIT(17),
   537		},
   538		[IMX8MN_DISPBLK_PD_MIPI_CSI] = {
   539			.name = "dispblk-mipi-csi",
   540			.clk_names = (const char *[]){ "csi-aclk", "csi-pclk" },
   541			.num_clks = 2,
   542			.gpc_name = "mipi-csi",
   543			.rst_mask = BIT(2) | BIT(3),
   544			.clk_mask = BIT(2) | BIT(3),
   545			.mipi_phy_rst_mask = BIT(16),
   546		},
   547		[IMX8MN_DISPBLK_PD_LCDIF] = {
   548			.name = "dispblk-lcdif",
   549			.clk_names = (const char *[]){ "lcdif-axi", "lcdif-apb", "lcdif-pix", },
   550			.num_clks = 3,
   551			.gpc_name = "lcdif",
   552			.rst_mask = BIT(4) | BIT(5),
   553			.clk_mask = BIT(4) | BIT(5),
   554		},
   555		[IMX8MN_DISPBLK_PD_ISI] = {
   556			.name = "dispblk-isi",
   557			.clk_names = (const char *[]){ "disp_axi", "disp_apb", "disp_axi_root",
   558							"disp_apb_root"},
   559			.num_clks = 4,
   560			.gpc_name = "isi",
   561			.rst_mask = BIT(6) | BIT(7),
   562			.clk_mask = BIT(6) | BIT(7),
   563		},
   564	};
   565	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel