All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH v5 08/17] powerpc/64s: Make flush_and_reload_slb a no-op when radix is enabled
Date: Mon, 29 Nov 2021 13:07:54 +1000	[thread overview]
Message-ID: <20211129030803.1888161-9-npiggin@gmail.com> (raw)
In-Reply-To: <20211129030803.1888161-1-npiggin@gmail.com>

The radix test can exclude slb_flush_all_realmode() from being called
because flush_and_reload_slb() is only expected to flush ERAT when
called by flush_erat(), which is only on pre-ISA v3.0 CPUs that do not
support radix.

This helps the later change to make hash support configurable to not
introduce runtime changes to radix mode behaviour.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/kernel/mce_power.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/mce_power.c b/arch/powerpc/kernel/mce_power.c
index c2f55fe7092d..cf5263b648fc 100644
--- a/arch/powerpc/kernel/mce_power.c
+++ b/arch/powerpc/kernel/mce_power.c
@@ -80,12 +80,12 @@ static bool mce_in_guest(void)
 #ifdef CONFIG_PPC_BOOK3S_64
 void flush_and_reload_slb(void)
 {
-	/* Invalidate all SLBs */
-	slb_flush_all_realmode();
-
 	if (early_radix_enabled())
 		return;
 
+	/* Invalidate all SLBs */
+	slb_flush_all_realmode();
+
 	/*
 	 * This probably shouldn't happen, but it may be possible it's
 	 * called in early boot before SLB shadows are allocated.
-- 
2.23.0


  parent reply	other threads:[~2021-11-29  3:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29  3:07 [PATCH v5 00/17] powerpc: Make hash MMU code build configurable Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 01/17] powerpc: Remove unused FW_FEATURE_NATIVE references Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 02/17] powerpc: Rename PPC_NATIVE to PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 03/17] powerpc/pseries: Stop selecting PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 04/17] powerpc/64s: Move and rename do_bad_slb_fault as it is not hash specific Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 05/17] powerpc/pseries: move process table registration away from hash-specific code Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 06/17] powerpc/pseries: lparcfg don't include slb_size line in radix mode Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 07/17] powerpc/64s: move THP trace point creation out of hash specific file Nicholas Piggin
2021-11-29  3:07 ` Nicholas Piggin [this message]
2021-11-29  3:07 ` [PATCH v5 09/17] powerpc/64s: move page size definitions from " Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 10/17] powerpc/64s: Rename hash_hugetlbpage.c to hugetlbpage.c Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 11/17] powerpc/64: pcpu setup avoid reading mmu_linear_psize on 64e or radix Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 12/17] powerpc: make memremap_compat_align 64s-only Nicholas Piggin
2021-11-29  3:07 ` [PATCH v5 13/17] powerpc/64e: remove mmu_linear_psize Nicholas Piggin
2021-11-29  3:08 ` [PATCH v5 14/17] powerpc/64s: Fix radix MMU when MMU_FTR_HPTE_TABLE is clear Nicholas Piggin
2021-11-29  3:08 ` [PATCH v5 15/17] powerpc/64s: Make hash MMU support configurable Nicholas Piggin
2021-11-29 13:46   ` Fabiano Rosas
2021-12-01  5:13     ` Nicholas Piggin
2021-11-29  3:08 ` [PATCH v5 16/17] powerpc/64s: Move hash MMU support code under CONFIG_PPC_64S_HASH_MMU Nicholas Piggin
2021-11-29  3:08 ` [PATCH v5 17/17] powerpc/microwatt: add POWER9_CPU, clear PPC_64S_HASH_MMU Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129030803.1888161-9-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.