All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Sean Nyekjaer <sean@geanix.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend
Date: Mon, 29 Nov 2021 10:19:08 +0100	[thread overview]
Message-ID: <20211129101908.6f1aa715@xps13> (raw)
In-Reply-To: <20211123140715.280b2f70@collabora.com>

Hi Sean,

boris.brezillon@collabora.com wrote on Tue, 23 Nov 2021 14:07:15 +0100:

> On Tue, 23 Nov 2021 13:50:12 +0100
> Sean Nyekjaer <sean@geanix.com> wrote:
> 
> > @Boris do we need to do something similar here to what we did with the
> > mtdconcat stuff?  
> 
> Absolutely, physmasp subdevices are never initialized/registered, so
> you can't call any of the mtd helpers taking the suspend lock on those.
> I guess it'd be better to call mtd_suspend/resume() on the concat device
> in though:

Any chance that you will come up with a fix or v6 of the series anytime
soon?

> 
> static void physmap_flash_shutdown(struct platform_device *dev)
> {
> 	struct physmap_flash_info *info = platform_get_drvdata(dev);
> 
> 	mtd_suspend(info->cmtd);
> }


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Sean Nyekjaer <sean@geanix.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend
Date: Mon, 29 Nov 2021 10:19:08 +0100	[thread overview]
Message-ID: <20211129101908.6f1aa715@xps13> (raw)
In-Reply-To: <20211123140715.280b2f70@collabora.com>

Hi Sean,

boris.brezillon@collabora.com wrote on Tue, 23 Nov 2021 14:07:15 +0100:

> On Tue, 23 Nov 2021 13:50:12 +0100
> Sean Nyekjaer <sean@geanix.com> wrote:
> 
> > @Boris do we need to do something similar here to what we did with the
> > mtdconcat stuff?  
> 
> Absolutely, physmasp subdevices are never initialized/registered, so
> you can't call any of the mtd helpers taking the suspend lock on those.
> I guess it'd be better to call mtd_suspend/resume() on the concat device
> in though:

Any chance that you will come up with a fix or v6 of the series anytime
soon?

> 
> static void physmap_flash_shutdown(struct platform_device *dev)
> {
> 	struct physmap_flash_info *info = platform_get_drvdata(dev);
> 
> 	mtd_suspend(info->cmtd);
> }


Thanks,
Miquèl

  reply	other threads:[~2021-11-29  9:20 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 11:02 [PATCH v5 0/4] mtd: core: protect access to mtd devices while in suspend Sean Nyekjaer
2021-11-02 11:02 ` Sean Nyekjaer
2021-11-02 11:02 ` [PATCH v5 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Sean Nyekjaer
2021-11-02 11:02   ` Sean Nyekjaer
2021-11-19 18:35   ` Miquel Raynal
2021-11-19 18:35     ` Miquel Raynal
2021-11-02 11:02 ` [PATCH v5 2/4] mtd: mtdconcat: don't use mtd_{suspend,resume}() Sean Nyekjaer
2021-11-02 11:02   ` Sean Nyekjaer
2021-11-19 18:35   ` Miquel Raynal
2021-11-19 18:35     ` Miquel Raynal
2021-11-02 11:02 ` [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend Sean Nyekjaer
2021-11-02 11:02   ` Sean Nyekjaer
2021-11-19 18:35   ` Miquel Raynal
2021-11-19 18:35     ` Miquel Raynal
2021-11-23 12:03   ` Marek Szyprowski
2021-11-23 12:03     ` Marek Szyprowski
2021-11-23 12:50     ` Sean Nyekjaer
2021-11-23 12:50       ` Sean Nyekjaer
2021-11-23 13:07       ` Boris Brezillon
2021-11-23 13:07         ` Boris Brezillon
2021-11-29  9:19         ` Miquel Raynal [this message]
2021-11-29  9:19           ` Miquel Raynal
2021-11-29  9:41           ` Sean Nyekjaer
2021-11-29  9:41             ` Sean Nyekjaer
2021-11-29 11:17             ` Marek Szyprowski
2021-11-29 11:17               ` Marek Szyprowski
2021-11-30 12:41               ` Sean Nyekjaer
2021-11-30 12:41                 ` Sean Nyekjaer
2021-11-30 13:15                 ` Boris Brezillon
2021-11-30 13:15                   ` Boris Brezillon
2021-11-30 13:29                   ` Sean Nyekjaer
2021-11-30 13:29                     ` Sean Nyekjaer
2021-11-30 13:37                     ` Boris Brezillon
2021-11-30 13:37                       ` Boris Brezillon
2021-12-03 13:39                       ` Miquel Raynal
2021-12-03 13:39                         ` Miquel Raynal
2021-12-09 14:07                         ` Sean Nyekjaer
2021-12-09 14:07                           ` Sean Nyekjaer
2021-12-09 14:28                           ` Miquel Raynal
2021-12-09 14:28                             ` Miquel Raynal
2021-12-10 13:25                             ` Sean Nyekjaer
2021-12-10 13:25                               ` Sean Nyekjaer
2021-12-13  9:10                               ` Miquel Raynal
2021-12-13  9:10                                 ` Miquel Raynal
2021-12-13  9:28                                 ` Boris Brezillon
2021-12-13  9:28                                   ` Boris Brezillon
2021-12-13  9:33                                   ` Miquel Raynal
2021-12-13  9:33                                     ` Miquel Raynal
2021-12-13  9:53                                     ` Boris Brezillon
2021-12-13  9:53                                       ` Boris Brezillon
2021-12-13 10:50                                       ` Sean Nyekjaer
2021-12-13 10:50                                         ` Sean Nyekjaer
2021-12-13 11:06                                         ` Boris Brezillon
2021-12-13 11:06                                           ` Boris Brezillon
2021-11-02 11:02 ` [PATCH v5 4/4] mtd: rawnand: remove suspended check Sean Nyekjaer
2021-11-02 11:02   ` Sean Nyekjaer
2021-11-19 18:35   ` Miquel Raynal
2021-11-19 18:35     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129101908.6f1aa715@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=richard@nod.at \
    --cc=sean@geanix.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.