From: kernel test robot <lkp@intel.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [RFC PATCH net] net: ipv6: make fib6_nh_init properly clean after itself on error
Date: Tue, 30 Nov 2021 05:23:46 +0800 [thread overview]
Message-ID: <202111300529.K2YL6F1D-lkp@intel.com> (raw)
In-Reply-To: <20211129141151.490533-1-razor@blackwall.org>
Hi Nikolay,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-ipv6-make-fib6_nh_init-properly-clean-after-itself-on-error/20211130-001132
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2191b1dfef7d45f44b5008d2148676d9f2c82874
config: i386-randconfig-r002-20211128 (https://download.01.org/0day-ci/archive/20211130/202111300529.K2YL6F1D-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2db1685345b4a1aecadba0a8197c79f5e49da8ec
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nikolay-Aleksandrov/net-ipv6-make-fib6_nh_init-properly-clean-after-itself-on-error/20211130-001132
git checkout 2db1685345b4a1aecadba0a8197c79f5e49da8ec
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv4/nexthop.c:2570:1: warning: unused label 'out' [-Wunused-label]
out:
^~~~
1 warning generated.
vim +/out +2570 net/ipv4/nexthop.c
597cfe4fc3390a David Ahern 2019-05-24 2544
53010f991a9f5e David Ahern 2019-05-24 2545 static int nh_create_ipv6(struct net *net, struct nexthop *nh,
53010f991a9f5e David Ahern 2019-05-24 2546 struct nh_info *nhi, struct nh_config *cfg,
53010f991a9f5e David Ahern 2019-05-24 2547 struct netlink_ext_ack *extack)
53010f991a9f5e David Ahern 2019-05-24 2548 {
53010f991a9f5e David Ahern 2019-05-24 2549 struct fib6_nh *fib6_nh = &nhi->fib6_nh;
53010f991a9f5e David Ahern 2019-05-24 2550 struct fib6_config fib6_cfg = {
53010f991a9f5e David Ahern 2019-05-24 2551 .fc_table = l3mdev_fib_table(cfg->dev),
53010f991a9f5e David Ahern 2019-05-24 2552 .fc_ifindex = cfg->nh_ifindex,
53010f991a9f5e David Ahern 2019-05-24 2553 .fc_gateway = cfg->gw.ipv6,
53010f991a9f5e David Ahern 2019-05-24 2554 .fc_flags = cfg->nh_flags,
9aca491e0dccf8 Ryoga Saito 2021-09-02 2555 .fc_nlinfo = cfg->nlinfo,
b513bd035f4044 David Ahern 2019-05-24 2556 .fc_encap = cfg->nh_encap,
b513bd035f4044 David Ahern 2019-05-24 2557 .fc_encap_type = cfg->nh_encap_type,
38428d68719c45 Roopa Prabhu 2020-05-21 2558 .fc_is_fdb = cfg->nh_fdb,
53010f991a9f5e David Ahern 2019-05-24 2559 };
6f43e5252833f3 Colin Ian King 2019-05-30 2560 int err;
53010f991a9f5e David Ahern 2019-05-24 2561
53010f991a9f5e David Ahern 2019-05-24 2562 if (!ipv6_addr_any(&cfg->gw.ipv6))
53010f991a9f5e David Ahern 2019-05-24 2563 fib6_cfg.fc_flags |= RTF_GATEWAY;
53010f991a9f5e David Ahern 2019-05-24 2564
53010f991a9f5e David Ahern 2019-05-24 2565 /* sets nh_dev if successful */
53010f991a9f5e David Ahern 2019-05-24 2566 err = ipv6_stub->fib6_nh_init(net, fib6_nh, &fib6_cfg, GFP_KERNEL,
53010f991a9f5e David Ahern 2019-05-24 2567 extack);
2db1685345b4a1 Nikolay Aleksandrov 2021-11-29 2568 if (!err)
53010f991a9f5e David Ahern 2019-05-24 2569 nh->nh_flags = fib6_nh->fib_nh_flags;
1c743127cc54b1 Nikolay Aleksandrov 2021-11-23 @2570 out:
53010f991a9f5e David Ahern 2019-05-24 2571 return err;
53010f991a9f5e David Ahern 2019-05-24 2572 }
53010f991a9f5e David Ahern 2019-05-24 2573
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH net] net: ipv6: make fib6_nh_init properly clean after itself on error
Date: Tue, 30 Nov 2021 05:23:46 +0800 [thread overview]
Message-ID: <202111300529.K2YL6F1D-lkp@intel.com> (raw)
In-Reply-To: <20211129141151.490533-1-razor@blackwall.org>
[-- Attachment #1: Type: text/plain, Size: 4185 bytes --]
Hi Nikolay,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-ipv6-make-fib6_nh_init-properly-clean-after-itself-on-error/20211130-001132
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2191b1dfef7d45f44b5008d2148676d9f2c82874
config: i386-randconfig-r002-20211128 (https://download.01.org/0day-ci/archive/20211130/202111300529.K2YL6F1D-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2db1685345b4a1aecadba0a8197c79f5e49da8ec
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nikolay-Aleksandrov/net-ipv6-make-fib6_nh_init-properly-clean-after-itself-on-error/20211130-001132
git checkout 2db1685345b4a1aecadba0a8197c79f5e49da8ec
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv4/nexthop.c:2570:1: warning: unused label 'out' [-Wunused-label]
out:
^~~~
1 warning generated.
vim +/out +2570 net/ipv4/nexthop.c
597cfe4fc3390a David Ahern 2019-05-24 2544
53010f991a9f5e David Ahern 2019-05-24 2545 static int nh_create_ipv6(struct net *net, struct nexthop *nh,
53010f991a9f5e David Ahern 2019-05-24 2546 struct nh_info *nhi, struct nh_config *cfg,
53010f991a9f5e David Ahern 2019-05-24 2547 struct netlink_ext_ack *extack)
53010f991a9f5e David Ahern 2019-05-24 2548 {
53010f991a9f5e David Ahern 2019-05-24 2549 struct fib6_nh *fib6_nh = &nhi->fib6_nh;
53010f991a9f5e David Ahern 2019-05-24 2550 struct fib6_config fib6_cfg = {
53010f991a9f5e David Ahern 2019-05-24 2551 .fc_table = l3mdev_fib_table(cfg->dev),
53010f991a9f5e David Ahern 2019-05-24 2552 .fc_ifindex = cfg->nh_ifindex,
53010f991a9f5e David Ahern 2019-05-24 2553 .fc_gateway = cfg->gw.ipv6,
53010f991a9f5e David Ahern 2019-05-24 2554 .fc_flags = cfg->nh_flags,
9aca491e0dccf8 Ryoga Saito 2021-09-02 2555 .fc_nlinfo = cfg->nlinfo,
b513bd035f4044 David Ahern 2019-05-24 2556 .fc_encap = cfg->nh_encap,
b513bd035f4044 David Ahern 2019-05-24 2557 .fc_encap_type = cfg->nh_encap_type,
38428d68719c45 Roopa Prabhu 2020-05-21 2558 .fc_is_fdb = cfg->nh_fdb,
53010f991a9f5e David Ahern 2019-05-24 2559 };
6f43e5252833f3 Colin Ian King 2019-05-30 2560 int err;
53010f991a9f5e David Ahern 2019-05-24 2561
53010f991a9f5e David Ahern 2019-05-24 2562 if (!ipv6_addr_any(&cfg->gw.ipv6))
53010f991a9f5e David Ahern 2019-05-24 2563 fib6_cfg.fc_flags |= RTF_GATEWAY;
53010f991a9f5e David Ahern 2019-05-24 2564
53010f991a9f5e David Ahern 2019-05-24 2565 /* sets nh_dev if successful */
53010f991a9f5e David Ahern 2019-05-24 2566 err = ipv6_stub->fib6_nh_init(net, fib6_nh, &fib6_cfg, GFP_KERNEL,
53010f991a9f5e David Ahern 2019-05-24 2567 extack);
2db1685345b4a1 Nikolay Aleksandrov 2021-11-29 2568 if (!err)
53010f991a9f5e David Ahern 2019-05-24 2569 nh->nh_flags = fib6_nh->fib_nh_flags;
1c743127cc54b1 Nikolay Aleksandrov 2021-11-23 @2570 out:
53010f991a9f5e David Ahern 2019-05-24 2571 return err;
53010f991a9f5e David Ahern 2019-05-24 2572 }
53010f991a9f5e David Ahern 2019-05-24 2573
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-11-29 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 14:11 [RFC PATCH net] net: ipv6: make fib6_nh_init properly clean after itself on error Nikolay Aleksandrov
2021-11-29 21:23 ` kernel test robot [this message]
2021-11-29 21:23 ` kernel test robot
2021-11-30 12:40 ` Ido Schimmel
2021-11-30 12:48 ` Nikolay Aleksandrov
2021-11-30 16:01 ` David Ahern
2021-11-30 16:45 ` Nikolay Aleksandrov
2021-11-30 17:18 ` David Ahern
2021-11-30 21:30 ` Nikolay Aleksandrov
-- strict thread matches above, loose matches on Subject: below --
2021-11-30 1:18 kernel test robot
2021-12-08 3:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111300529.K2YL6F1D-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=llvm@lists.linux.dev \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.