All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	matthew.auld@intel.com,
	"Christian König" <christian.koenig@amd.com>
Subject: [Intel-gfx] [RFC PATCH 0/2] Attempt to avoid dma-fence-[chain|array] lockdep splats
Date: Tue, 30 Nov 2021 13:19:34 +0100	[thread overview]
Message-ID: <20211130121936.586031-1-thomas.hellstrom@linux.intel.com> (raw)

Introducing more usage of dma-fence-chain and dma-fence-array in the
i915 driver we start to hit lockdep splats due to the recursive fence
locking in the dma-fence-chain and dma-fence-array containers.
This is a humble suggestion to try to establish a dma-fence locking order
(patch 1) and to avoid excessive recursive locking in these containers
(patch 2)

Thomas Hellström (2):
  dma-fence: Avoid establishing a locking order between fence classes
  dma-fence: Avoid excessive recursive fence locking from
    enable_signaling() callbacks

 drivers/dma-buf/dma-fence-array.c | 23 +++++++--
 drivers/dma-buf/dma-fence-chain.c | 12 ++++-
 drivers/dma-buf/dma-fence.c       | 79 +++++++++++++++++++++----------
 include/linux/dma-fence.h         |  4 ++
 4 files changed, 89 insertions(+), 29 deletions(-)

Cc: linaro-mm-sig@lists.linaro.org
Cc: dri-devel@lists.freedesktop.org
Cc: Christian König <christian.koenig@amd.com>

-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	matthew.auld@intel.com,
	"Christian König" <christian.koenig@amd.com>
Subject: [RFC PATCH 0/2] Attempt to avoid dma-fence-[chain|array] lockdep splats
Date: Tue, 30 Nov 2021 13:19:34 +0100	[thread overview]
Message-ID: <20211130121936.586031-1-thomas.hellstrom@linux.intel.com> (raw)

Introducing more usage of dma-fence-chain and dma-fence-array in the
i915 driver we start to hit lockdep splats due to the recursive fence
locking in the dma-fence-chain and dma-fence-array containers.
This is a humble suggestion to try to establish a dma-fence locking order
(patch 1) and to avoid excessive recursive locking in these containers
(patch 2)

Thomas Hellström (2):
  dma-fence: Avoid establishing a locking order between fence classes
  dma-fence: Avoid excessive recursive fence locking from
    enable_signaling() callbacks

 drivers/dma-buf/dma-fence-array.c | 23 +++++++--
 drivers/dma-buf/dma-fence-chain.c | 12 ++++-
 drivers/dma-buf/dma-fence.c       | 79 +++++++++++++++++++++----------
 include/linux/dma-fence.h         |  4 ++
 4 files changed, 89 insertions(+), 29 deletions(-)

Cc: linaro-mm-sig@lists.linaro.org
Cc: dri-devel@lists.freedesktop.org
Cc: Christian König <christian.koenig@amd.com>

-- 
2.31.1


             reply	other threads:[~2021-11-30 12:19 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 12:19 Thomas Hellström [this message]
2021-11-30 12:19 ` [RFC PATCH 0/2] Attempt to avoid dma-fence-[chain|array] lockdep splats Thomas Hellström
2021-11-30 12:19 ` [Intel-gfx] [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes Thomas Hellström
2021-11-30 12:19   ` Thomas Hellström
2021-11-30 12:25   ` [Intel-gfx] " Maarten Lankhorst
2021-11-30 12:25     ` Maarten Lankhorst
2021-11-30 12:31     ` [Intel-gfx] " Thomas Hellström
2021-11-30 12:31       ` Thomas Hellström
2021-11-30 12:42       ` [Intel-gfx] " Christian König
2021-11-30 12:42         ` Christian König
2021-11-30 12:56         ` [Intel-gfx] " Thomas Hellström
2021-11-30 12:56           ` Thomas Hellström
2021-11-30 13:26           ` [Intel-gfx] " Christian König
2021-11-30 13:26             ` Christian König
2021-11-30 14:35             ` [Intel-gfx] " Thomas Hellström
2021-11-30 14:35               ` Thomas Hellström
2021-11-30 15:02               ` [Intel-gfx] " Christian König
2021-11-30 15:02                 ` Christian König
2021-11-30 18:12                 ` [Intel-gfx] " Thomas Hellström
2021-11-30 18:12                   ` Thomas Hellström
2021-11-30 19:27                   ` [Intel-gfx] " Thomas Hellström
2021-11-30 19:27                     ` Thomas Hellström
2021-12-01  7:05                     ` [Intel-gfx] " Christian König
2021-12-01  7:05                       ` Christian König
2021-12-01  8:23                       ` [Intel-gfx] [Linaro-mm-sig] " Thomas Hellström (Intel)
2021-12-01  8:23                         ` Thomas Hellström (Intel)
2021-12-01  8:36                         ` [Intel-gfx] " Christian König
2021-12-01  8:36                           ` Christian König
2021-12-01 10:15                           ` [Intel-gfx] " Thomas Hellström (Intel)
2021-12-01 10:15                             ` Thomas Hellström (Intel)
2021-12-01 10:32                             ` [Intel-gfx] " Christian König
2021-12-01 10:32                               ` Christian König
2021-12-01 11:04                               ` [Intel-gfx] " Thomas Hellström (Intel)
2021-12-01 11:04                                 ` Thomas Hellström (Intel)
2021-12-01 11:25                                 ` [Intel-gfx] " Christian König
2021-12-01 11:25                                   ` Christian König
2021-12-01 12:16                                   ` [Intel-gfx] " Thomas Hellström (Intel)
2021-12-01 12:16                                     ` Thomas Hellström (Intel)
2021-12-03 13:08                                     ` [Intel-gfx] " Christian König
2021-12-03 13:08                                       ` Christian König
2021-12-03 14:18                                       ` [Intel-gfx] " Thomas Hellström
2021-12-03 14:18                                         ` Thomas Hellström
2021-12-03 14:26                                         ` [Intel-gfx] " Christian König
2021-12-03 14:26                                           ` Christian König
2021-12-03 14:50                                           ` [Intel-gfx] " Thomas Hellström
2021-12-03 14:50                                             ` Thomas Hellström
2021-12-03 15:00                                             ` [Intel-gfx] " Christian König
2021-12-03 15:00                                               ` Christian König
2021-12-03 15:13                                               ` [Intel-gfx] " Thomas Hellström (Intel)
2021-12-03 15:13                                                 ` Thomas Hellström (Intel)
2021-12-07 18:08                                         ` [Intel-gfx] " Daniel Vetter
2021-12-07 18:08                                           ` Daniel Vetter
2021-12-07 20:46                                           ` Thomas Hellström
2021-12-07 20:46                                             ` Thomas Hellström
2021-12-20  9:37                                             ` Daniel Vetter
2021-12-20  9:37                                               ` Daniel Vetter
2021-11-30 12:32   ` [Intel-gfx] " Thomas Hellström
2021-11-30 12:32     ` Thomas Hellström
2021-11-30 12:19 ` [Intel-gfx] [RFC PATCH 2/2] dma-fence: Avoid excessive recursive fence locking from enable_signaling() callbacks Thomas Hellström
2021-11-30 12:19   ` Thomas Hellström
2021-11-30 12:36 ` [Intel-gfx] [RFC PATCH 0/2] Attempt to avoid dma-fence-[chain|array] lockdep splats Christian König
2021-11-30 12:36   ` Christian König
2021-11-30 13:05 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2021-11-30 13:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-30 17:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130121936.586031-1-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.